issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 279832457 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 2 ✖

issue 1

  • Multi-dimensional coordinate mixup when writing to netCDF · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
350079436 https://github.com/pydata/xarray/issues/1763#issuecomment-350079436 https://api.github.com/repos/pydata/xarray/issues/1763 MDEyOklzc3VlQ29tbWVudDM1MDA3OTQzNg== shoyer 1217238 2017-12-07T20:05:57Z 2017-12-07T20:05:57Z MEMBER

I know the DataArray objects (foo1,foo2,foo3) already have the right coordinates associated with them before writing to netCDF, so maybe the logic in _encode_coordinates could be changed to utilize v.coords somehow?

DataArray objects get appropriate coordinates when indexed from a Dataset by using the following logic: https://github.com/pydata/xarray/blob/3a28b611e40f2a09c05f982242f638cc3f7d94bf/xarray/core/dataset.py#L785-L789

We could should duplicate the same logic for encoding coordinates on particular variables.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Multi-dimensional coordinate mixup when writing to netCDF 279832457
349821087 https://github.com/pydata/xarray/issues/1763#issuecomment-349821087 https://api.github.com/repos/pydata/xarray/issues/1763 MDEyOklzc3VlQ29tbWVudDM0OTgyMTA4Nw== shoyer 1217238 2017-12-07T00:30:39Z 2017-12-07T00:31:21Z MEMBER

It looks like currently write coordinates in data variable attributes if the share any dimensions in common. This should probably be updated to require that all dimensions match: https://github.com/pydata/xarray/blob/c2b205f29467a4431baa80b5c07fe31bda67fbef/xarray/conventions.py#L1217-L1220

Any interest in putting together a pull request to fix this? :)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Multi-dimensional coordinate mixup when writing to netCDF 279832457

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);