issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 278713328 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Deprecate inplace methods · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
476340665 https://github.com/pydata/xarray/issues/1756#issuecomment-476340665 https://api.github.com/repos/pydata/xarray/issues/1756 MDEyOklzc3VlQ29tbWVudDQ3NjM0MDY2NQ== shoyer 1217238 2019-03-25T19:19:10Z 2019-03-25T19:19:10Z MEMBER

The plan is to keep around the update() method, which will always be inplace. So that's one option.

On Mon, Mar 25, 2019 at 11:54 AM Nathan Lyons notifications@github.com wrote:

Is there a recommendation for merging a dataset without inplacewhen the dataset is a subclass of xr.Dataset, other than through composition? Perhaps lower level functions to merge?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/1756#issuecomment-476332195, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1j_EqfrXRLdXtKgy_wQFVpk27vMgks5vaRtYgaJpZM4QzchO . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecate inplace methods 278713328
457426843 https://github.com/pydata/xarray/issues/1756#issuecomment-457426843 https://api.github.com/repos/pydata/xarray/issues/1756 MDEyOklzc3VlQ29tbWVudDQ1NzQyNjg0Mw== shoyer 1217238 2019-01-25T01:52:54Z 2019-01-25T01:52:54Z MEMBER

We will probably actually wait longer than until 0.12 for removing this argument, depending on the timing for that release.

Unfortunately our API is indeed not entirely stable yet -- that's why the version number is still 0.X, not 1.X.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecate inplace methods 278713328
457425756 https://github.com/pydata/xarray/issues/1756#issuecomment-457425756 https://api.github.com/repos/pydata/xarray/issues/1756 MDEyOklzc3VlQ29tbWVudDQ1NzQyNTc1Ng== jhamman 2443309 2019-01-25T01:46:36Z 2019-01-25T01:46:36Z MEMBER

@st-bender - sorry to hear this change has caught you by surprise. We're a ways off from 0.12 so you should have time to work in any necessary changes before the feature if fully removed. If you have questions about how to adjust our use these methods, let us know. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Deprecate inplace methods 278713328

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);