home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

5 rows where author_association = "MEMBER", issue = 276241193 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

These facets timed out: author_association

user 1

  • shoyer · 5 ✖

issue 1

  • Windows/Python 2.7 tests of dask-distributed failing on master/v0.10.0 · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
347813738 https://github.com/pydata/xarray/issues/1738#issuecomment-347813738 https://api.github.com/repos/pydata/xarray/issues/1738 MDEyOklzc3VlQ29tbWVudDM0NzgxMzczOA== shoyer 1217238 2017-11-29T10:12:13Z 2017-11-29T10:12:13Z MEMBER

One useful clue: when I run these tests on OS X, I get the following warnings: ``` ========================================= warnings summary ========================================== xarray/tests/test_distributed.py::test_dask_distributed_integration_test[scipy] /Users/shoyer/conda/envs/xarray-py36/lib/python3.6/site-packages/distributed/utils_test.py:528: UserWarning: This test leaked 8 file descriptors warnings.warn("This test leaked %d file descriptors" % diff) /Users/shoyer/conda/envs/xarray-py36/lib/python3.6/site-packages/distributed/utils_test.py:538: UserWarning: This test leaked 15 MB of memory warnings.warn("This test leaked %d MB of memory" % diff)

xarray/tests/test_distributed.py::test_dask_distributed_integration_test[netcdf4] /Users/shoyer/conda/envs/xarray-py36/lib/python3.6/site-packages/distributed/utils_test.py:528: UserWarning: This test leaked 6 file descriptors warnings.warn("This test leaked %d file descriptors" % diff)

-- Docs: http://doc.pytest.org/en/latest/warnings.html ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Windows/Python 2.7 tests of dask-distributed failing on master/v0.10.0 276241193
346681481 https://github.com/pydata/xarray/issues/1738#issuecomment-346681481 https://api.github.com/repos/pydata/xarray/issues/1738 MDEyOklzc3VlQ29tbWVudDM0NjY4MTQ4MQ== shoyer 1217238 2017-11-23T18:43:15Z 2017-11-23T18:43:15Z MEMBER

This is Python 2.7.14.

We do have a build against git master for dask, but only on Linux (Appveyor only gives us one free simultaneous build).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Windows/Python 2.7 tests of dask-distributed failing on master/v0.10.0 276241193
346670059 https://github.com/pydata/xarray/issues/1738#issuecomment-346670059 https://api.github.com/repos/pydata/xarray/issues/1738 MDEyOklzc3VlQ29tbWVudDM0NjY3MDA1OQ== shoyer 1217238 2017-11-23T17:20:46Z 2017-11-23T17:20:46Z MEMBER

Comparing a failed build to the last successful build on master, I find the following difference in the dependencies: ```

passed, just before the v0.10.0 release

ca-certificates 2017.7.27.1 0 conda-forge dask 0.15.4 py_0 conda-forge dask-core 0.15.4 py_0 conda-forge distributed 1.19.3 py27_0 conda-forge setuptools 36.6.0 py27_1 conda-forge

failed, at the v0.10.0 release

ca-certificates 2017.11.5 0 conda-forge dask 0.16.0 py_0 conda-forge dask-core 0.16.0 py_0 conda-forge distributed 1.20.0 py27_0 conda-forge setuptools 36.7.2 py27_0 conda-forge `` It looks like dask 0.16 or distributed 0.1.20 release is the most likely culprit. There were no Python changes to xarray in the v0.10.0 release commit (onlysetup.py` and documentation changes).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Windows/Python 2.7 tests of dask-distributed failing on master/v0.10.0 276241193
346512099 https://github.com/pydata/xarray/issues/1738#issuecomment-346512099 https://api.github.com/repos/pydata/xarray/issues/1738 MDEyOklzc3VlQ29tbWVudDM0NjUxMjA5OQ== shoyer 1217238 2017-11-23T01:04:57Z 2017-11-23T01:04:57Z MEMBER

It definitely started recently (past week). I don't think we changed anything relevant in xarray so my guess is something to do with a dependency. Hopefully it will be clear from the appveyor logs! On Wed, Nov 22, 2017 at 4:49 PM Matthew Rocklin notifications@github.com wrote:

If I may generalize the question, did this start happening recently? Do we know what triggered this change?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/1738#issuecomment-346510516, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1hI27jKOwumHya6BpXxDcQNa_Hn1ks5s5MEXgaJpZM4QoKTw .

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Windows/Python 2.7 tests of dask-distributed failing on master/v0.10.0 276241193
346510438 https://github.com/pydata/xarray/issues/1738#issuecomment-346510438 https://api.github.com/repos/pydata/xarray/issues/1738 MDEyOklzc3VlQ29tbWVudDM0NjUxMDQzOA== shoyer 1217238 2017-11-23T00:48:35Z 2017-11-23T00:48:35Z MEMBER

It looks like it, I'll double check.

On Wed, Nov 22, 2017 at 4:46 PM Matthew Rocklin notifications@github.com wrote:

At first glance, no. Does this happen both on latest release and on git-master?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/1738#issuecomment-346510216, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1vBBuWl_-ilWNa7yrd2bIiI6c8vkks5s5MBmgaJpZM4QoKTw .

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Windows/Python 2.7 tests of dask-distributed failing on master/v0.10.0 276241193

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 3200.138ms · About: xarray-datasette