issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 276131376 and user = 10050469 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • fmaussion · 2 ✖

issue 1

  • Rasterio missing _FillValue in DataArray · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
346427925 https://github.com/pydata/xarray/issues/1736#issuecomment-346427925 https://api.github.com/repos/pydata/xarray/issues/1736 MDEyOklzc3VlQ29tbWVudDM0NjQyNzkyNQ== fmaussion 10050469 2017-11-22T17:56:18Z 2017-11-22T17:56:18Z MEMBER

What I'm not sure, though, is if we should rename the attribute to _FillValue or keep its name as it is. I am also not sure if we should do the automatic conversion as it is done with the netCDF backends. Quite often geotiff files store iteger types, and filling with NaNs require floats.

Right now I would tend to just parse the nodatavals attribute and leave everything else to the user.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rasterio missing _FillValue in DataArray 276131376
346427043 https://github.com/pydata/xarray/issues/1736#issuecomment-346427043 https://api.github.com/repos/pydata/xarray/issues/1736 MDEyOklzc3VlQ29tbWVudDM0NjQyNzA0Mw== fmaussion 10050469 2017-11-22T17:52:48Z 2017-11-22T17:52:48Z MEMBER

I agree that it would be nice to have. It seems that the corresponding rasterio attribute is nodatavals (https://github.com/mapbox/rasterio/blob/master/docs/topics/masks.rst). It shouldn't be too difficult to add to the existing attributes: https://github.com/pydata/xarray/blob/master/xarray/backends/rasterio_.py#L142

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rasterio missing _FillValue in DataArray 276131376

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);