issue_comments

Table actions

8 rows where author_association = "MEMBER" and issue = 271180559 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Bugfix in broadcast_indexes · 8 ✖

author_association 1

  • MEMBER · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
342615444 https://github.com/pydata/xarray/pull/1693#issuecomment-342615444 https://api.github.com/repos/pydata/xarray/issues/1693 MDEyOklzc3VlQ29tbWVudDM0MjYxNTQ0NA== shoyer 1217238 2017-11-07T20:41:53Z 2017-11-07T20:41:53Z MEMBER

Thanks @fujiisoup, this is very helpful.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bugfix in broadcast_indexes 271180559
342351127 https://github.com/pydata/xarray/pull/1693#issuecomment-342351127 https://api.github.com/repos/pydata/xarray/issues/1693 MDEyOklzc3VlQ29tbWVudDM0MjM1MTEyNw== fujiisoup 6815844 2017-11-07T02:00:07Z 2017-11-07T02:00:24Z MEMBER

Found some an unfixed bug in #1676, where in some cases MemoryCachedArray, CopyOnWriteArray, LazilyIndexedArray have a bare np.ndarray, rather than NumpyIndexingArray.

I think this is now fixed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bugfix in broadcast_indexes 271180559
342315848 https://github.com/pydata/xarray/pull/1693#issuecomment-342315848 https://api.github.com/repos/pydata/xarray/issues/1693 MDEyOklzc3VlQ29tbWVudDM0MjMxNTg0OA== fujiisoup 6815844 2017-11-06T22:54:53Z 2017-11-06T22:54:53Z MEMBER

@shoyer Thanks. Merged from the master.

But I think I should also add another test for #1694 , which seems to be solved by this PR.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bugfix in broadcast_indexes 271180559
342221693 https://github.com/pydata/xarray/pull/1693#issuecomment-342221693 https://api.github.com/repos/pydata/xarray/issues/1693 MDEyOklzc3VlQ29tbWVudDM0MjIyMTY5Mw== shoyer 1217238 2017-11-06T17:23:48Z 2017-11-06T17:23:48Z MEMBER

@fujiisoup this needs a merge from master after your last PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bugfix in broadcast_indexes 271180559
342054274 https://github.com/pydata/xarray/pull/1693#issuecomment-342054274 https://api.github.com/repos/pydata/xarray/issues/1693 MDEyOklzc3VlQ29tbWVudDM0MjA1NDI3NA== fujiisoup 6815844 2017-11-06T06:01:16Z 2017-11-06T06:01:16Z MEMBER

I found and fixed the following bugs.

  1. Fix for #1579 was not perfect (indexing dask array by np.int fails).
  2. LazilyIndexingArray always used OuterIndexer. 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bugfix in broadcast_indexes 271180559
342045207 https://github.com/pydata/xarray/pull/1693#issuecomment-342045207 https://api.github.com/repos/pydata/xarray/issues/1693 MDEyOklzc3VlQ29tbWVudDM0MjA0NTIwNw== fujiisoup 6815844 2017-11-06T04:42:28Z 2017-11-06T04:42:28Z MEMBER

Found another bug. Not ready yet.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bugfix in broadcast_indexes 271180559
341888035 https://github.com/pydata/xarray/pull/1693#issuecomment-341888035 https://api.github.com/repos/pydata/xarray/issues/1693 MDEyOklzc3VlQ29tbWVudDM0MTg4ODAzNQ== fmaussion 10050469 2017-11-04T10:56:05Z 2017-11-04T15:51:14Z MEMBER

This code reproduces the error (one can probably clean it up a little):

import xarray as xr import numpy as np a = np.arange(1e5) da = xr.DataArray(a, coords:{'t':a}, dims=('t',)) da.to_netcdf('test.nc') t = xr.open_dataarray('test.nc') t.isel(t=t.t > 12)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bugfix in broadcast_indexes 271180559
341886302 https://github.com/pydata/xarray/pull/1693#issuecomment-341886302 https://api.github.com/repos/pydata/xarray/issues/1693 MDEyOklzc3VlQ29tbWVudDM0MTg4NjMwMg== fujiisoup 6815844 2017-11-04T10:23:13Z 2017-11-04T10:23:13Z MEMBER

I thought issue #1688 was already covered in test_backend.py but was not. If someone could suggest an appropriate test in test_backend.py, it would be super nice.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Bugfix in broadcast_indexes 271180559

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);