issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 269348789 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • max-sixty · 3 ✖

issue 1

  • Remove use of allow_cleanup_failure in test_backends.py · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
536336342 https://github.com/pydata/xarray/issues/1668#issuecomment-536336342 https://api.github.com/repos/pydata/xarray/issues/1668 MDEyOklzc3VlQ29tbWVudDUzNjMzNjM0Mg== max-sixty 5635139 2019-09-29T20:07:02Z 2019-09-29T20:07:02Z MEMBER

OK, yes I see now. I didn't know about that windows behavior. There's a broader CPython issue about it too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove use of allow_cleanup_failure in test_backends.py 269348789
536231578 https://github.com/pydata/xarray/issues/1668#issuecomment-536231578 https://api.github.com/repos/pydata/xarray/issues/1668 MDEyOklzc3VlQ29tbWVudDUzNjIzMTU3OA== max-sixty 5635139 2019-09-28T22:58:40Z 2019-09-28T22:58:40Z MEMBER

We currently try to explicitly close any temp files we created at the end of each test. Are you suggesting that we should leave that clean-up to the operating system?

IIUC (and my understand isn't advanced here!), python will close and delete temp files & directories once they leave scope:

From https://docs.python.org/3/library/tempfile.html#examples

```

create a temporary file using a context manager

with tempfile.TemporaryFile() as fp: ... fp.write(b'Hello world!') ... fp.seek(0) ... fp.read() b'Hello world!'

file is now closed and removed

``` https://docs.python.org/3/library/tempfile.html#tempfile.TemporaryDirectory

Or is it that we want to test that they're closed?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove use of allow_cleanup_failure in test_backends.py 269348789
536230085 https://github.com/pydata/xarray/issues/1668#issuecomment-536230085 https://api.github.com/repos/pydata/xarray/issues/1668 MDEyOklzc3VlQ29tbWVudDUzNjIzMDA4NQ== max-sixty 5635139 2019-09-28T22:26:03Z 2019-09-28T22:26:03Z MEMBER

Maybe I don't understand the whole problem—can we just use a temp dir for these?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Remove use of allow_cleanup_failure in test_backends.py 269348789

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);