issue_comments

Table actions

6 rows where author_association = "MEMBER", issue = 264049503 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • shoyer · 6 ✖

issue 1

  • Rules for propagating attrs and encoding · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
435621629 https://github.com/pydata/xarray/issues/1614#issuecomment-435621629 https://api.github.com/repos/pydata/xarray/issues/1614 MDEyOklzc3VlQ29tbWVudDQzNTYyMTYyOQ== shoyer 1217238 2018-11-03T21:18:11Z 2018-11-03T21:18:11Z MEMBER

I would happy to add a global keep_attrs option to xarray.set_options(), which we could use for controlling arithmetic. I'm not planning on working on it personally, but I would be happy to review a PR.

Note that this was implemented by @TomNicholas in https://github.com/pydata/xarray/pull/2482

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rules for propagating attrs and encoding 264049503
398204944 https://github.com/pydata/xarray/issues/1614#issuecomment-398204944 https://api.github.com/repos/pydata/xarray/issues/1614 MDEyOklzc3VlQ29tbWVudDM5ODIwNDk0NA== shoyer 1217238 2018-06-18T21:41:46Z 2018-06-18T21:41:46Z MEMBER

I would happy to add a global keep_attrs option to xarray.set_options(), which we could use for controlling arithmetic. I'm not planning on working on it personally, but I would be happy to review a PR.

 
{
    "total_count": 4,
    "+1": 4,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rules for propagating attrs and encoding 264049503
398197376 https://github.com/pydata/xarray/issues/1614#issuecomment-398197376 https://api.github.com/repos/pydata/xarray/issues/1614 MDEyOklzc3VlQ29tbWVudDM5ODE5NzM3Ng== shoyer 1217238 2018-06-18T21:12:18Z 2018-06-18T21:12:18Z MEMBER

No, just the proposed feature to keep or delete metadata based on the various operations. Is this behaviour already part of the library, and this issue is just to clarify the intended behaviour, or is this a feature proposal?

We already have most of this behavior (matching what @jhamman lists in the first comment), though it isn't clearly documented. It should just work if you use xarray methods/functions.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rules for propagating attrs and encoding 264049503
398153267 https://github.com/pydata/xarray/issues/1614#issuecomment-398153267 https://api.github.com/repos/pydata/xarray/issues/1614 MDEyOklzc3VlQ29tbWVudDM5ODE1MzI2Nw== shoyer 1217238 2018-06-18T18:36:50Z 2018-06-18T18:36:50Z MEMBER

Also - might I suggest you consider some kind of history tracker as part of the metadata propagation?

Certainly this would be out of scope for xarray itself, but this perhaps be done with a library that wraps xarray's API. If I recall correctly, @pwolfram was also interested in this.

We did discuss customizable hooks for attribute handling in #988 but I'm no longer sure that is a good idea. These sort of overloads are really hard to get right, as we've seen with NumPy's long history of different override protocols (the most recent example being __array_ufunc__).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rules for propagating attrs and encoding 264049503
398151360 https://github.com/pydata/xarray/issues/1614#issuecomment-398151360 https://api.github.com/repos/pydata/xarray/issues/1614 MDEyOklzc3VlQ29tbWVudDM5ODE1MTM2MA== shoyer 1217238 2018-06-18T18:30:16Z 2018-06-18T18:30:16Z MEMBER

Hi, this feature would be very relevant to the intended use case of a project I'd like to use xarray for. Is the behaviour discussed in the first post implemented anywhere, e.g. in the trunk, for me to play with?

are you referring to a different issue? the first post only summarizes some simple proposed rules.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rules for propagating attrs and encoding 264049503
362752398 https://github.com/pydata/xarray/issues/1614#issuecomment-362752398 https://api.github.com/repos/pydata/xarray/issues/1614 MDEyOklzc3VlQ29tbWVudDM2Mjc1MjM5OA== shoyer 1217238 2018-02-03T00:38:12Z 2018-02-03T00:38:12Z MEMBER

The challenge with a user-specified function is that there can potentially be weird conflicts if multiple libraries try to override it. Possibly it's worth it for the convenience, but subclasses allowing for explicit hooks (like numpy) is probably the cleanest solution.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Rules for propagating attrs and encoding 264049503

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);