issue_comments

Table actions

15 rows where author_association = "MEMBER" and issue = 261131958 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • Add methods for combining variables of differing dimensionality · 15 ✖

author_association 1

  • MEMBER · 15 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
508802305 https://github.com/pydata/xarray/pull/1597#issuecomment-508802305 https://api.github.com/repos/pydata/xarray/issues/1597 MDEyOklzc3VlQ29tbWVudDUwODgwMjMwNQ== jhamman 2443309 2019-07-05T15:57:31Z 2019-07-05T15:57:31Z MEMBER

Kudos to @nbren12 for sticking with this one! Looking forward to seeing this one in the wild. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add methods for combining variables of differing dimensionality 261131958
508595343 https://github.com/pydata/xarray/pull/1597#issuecomment-508595343 https://api.github.com/repos/pydata/xarray/issues/1597 MDEyOklzc3VlQ29tbWVudDUwODU5NTM0Mw== shoyer 1217238 2019-07-05T00:33:07Z 2019-07-05T00:33:07Z MEMBER

Thanks @nbren12!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add methods for combining variables of differing dimensionality 261131958
507895012 https://github.com/pydata/xarray/pull/1597#issuecomment-507895012 https://api.github.com/repos/pydata/xarray/issues/1597 MDEyOklzc3VlQ29tbWVudDUwNzg5NTAxMg== shoyer 1217238 2019-07-03T00:45:55Z 2019-07-03T00:45:55Z MEMBER

OK, I plan to merge this shortly unless there are any objections :)

 
{
    "total_count": 3,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 3,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add methods for combining variables of differing dimensionality 261131958
507791978 https://github.com/pydata/xarray/pull/1597#issuecomment-507791978 https://api.github.com/repos/pydata/xarray/issues/1597 MDEyOklzc3VlQ29tbWVudDUwNzc5MTk3OA== shoyer 1217238 2019-07-02T18:23:17Z 2019-07-02T18:23:17Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add methods for combining variables of differing dimensionality 261131958
494470057 https://github.com/pydata/xarray/pull/1597#issuecomment-494470057 https://api.github.com/repos/pydata/xarray/issues/1597 MDEyOklzc3VlQ29tbWVudDQ5NDQ3MDA1Nw== dcherian 2448579 2019-05-21T16:47:30Z 2019-05-21T16:47:30Z MEMBER

docs & tests LGTM. I don't understand stacking/unstacking/multiindexes too well...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add methods for combining variables of differing dimensionality 261131958
494240726 https://github.com/pydata/xarray/pull/1597#issuecomment-494240726 https://api.github.com/repos/pydata/xarray/issues/1597 MDEyOklzc3VlQ29tbWVudDQ5NDI0MDcyNg== jhamman 2443309 2019-05-21T05:04:24Z 2019-05-21T05:04:24Z MEMBER

@pydata/xarray - would love to get some more eyes on this PR. Its been lingering but @nbren12 seems to have addressed all prior comments.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add methods for combining variables of differing dimensionality 261131958
482645695 https://github.com/pydata/xarray/pull/1597#issuecomment-482645695 https://api.github.com/repos/pydata/xarray/issues/1597 MDEyOklzc3VlQ29tbWVudDQ4MjY0NTY5NQ== jhamman 2443309 2019-04-12T16:51:30Z 2019-04-12T16:51:30Z MEMBER

@rabernat - you had asked for some changes in the early days of this PR. Are you satisfied with the current state here?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add methods for combining variables of differing dimensionality 261131958
478749910 https://github.com/pydata/xarray/pull/1597#issuecomment-478749910 https://api.github.com/repos/pydata/xarray/issues/1597 MDEyOklzc3VlQ29tbWVudDQ3ODc0OTkxMA== shoyer 1217238 2019-04-01T21:12:09Z 2019-04-01T21:12:09Z MEMBER

No worries, rebase is fine too :)

On Mon, Apr 1, 2019 at 2:09 PM Noah D Brenowitz notifications@github.com wrote:

@shoyer https://github.com/shoyer Sorry. I rebased...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1597#issuecomment-478748969, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1g66J1a8H0wf1DzYQkEfqqIGGuc2ks5vcnWMgaJpZM4PmdUM . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add methods for combining variables of differing dimensionality 261131958
478730862 https://github.com/pydata/xarray/pull/1597#issuecomment-478730862 https://api.github.com/repos/pydata/xarray/issues/1597 MDEyOklzc3VlQ29tbWVudDQ3ODczMDg2Mg== shoyer 1217238 2019-04-01T20:17:33Z 2019-04-01T20:17:33Z MEMBER

@jhamman I did a little more work on this today. How do you recommend I update this to master? rebase?

We should add a section to our contributor guide on this, but the recommended workflow is just to use git merge.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add methods for combining variables of differing dimensionality 261131958
445291957 https://github.com/pydata/xarray/pull/1597#issuecomment-445291957 https://api.github.com/repos/pydata/xarray/issues/1597 MDEyOklzc3VlQ29tbWVudDQ0NTI5MTk1Nw== jhamman 2443309 2018-12-07T16:44:54Z 2018-12-07T16:44:54Z MEMBER

@nbren12 - can we revive this? There or some conflicts but I think this was pretty close to done.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add methods for combining variables of differing dimensionality 261131958
343718802 https://github.com/pydata/xarray/pull/1597#issuecomment-343718802 https://api.github.com/repos/pydata/xarray/issues/1597 MDEyOklzc3VlQ29tbWVudDM0MzcxODgwMg== shoyer 1217238 2017-11-12T07:29:22Z 2017-11-12T07:29:22Z MEMBER

@nbren12 OK, sounds good to me. Yes, it's a good idea to put more speculative stuff in other packages. I will take a look at your actual implementation.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add methods for combining variables of differing dimensionality 261131958
343626563 https://github.com/pydata/xarray/pull/1597#issuecomment-343626563 https://api.github.com/repos/pydata/xarray/issues/1597 MDEyOklzc3VlQ29tbWVudDM0MzYyNjU2Mw== shoyer 1217238 2017-11-11T01:04:03Z 2017-11-11T01:04:03Z MEMBER

@nbren12 in the linked issue (https://github.com/pydata/xarray/issues/1317#issuecomment-337796691) you wrote:

After using my own version of this code for the past month or so, it has occurred to me that this API probably will not support stacking arrays of with different sizes along shared arrays. For instance, I need to "stack" humidity below an altitude of 10km with temperature between 0 and 16 km. IMO, the easiest way to do this would be to change these methods into top-level functions which can take any dict or iterable of datarrays. We could leave that for a later PR of course.

Is this something that would make sense to resolve before we merge this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add methods for combining variables of differing dimensionality 261131958
338303735 https://github.com/pydata/xarray/pull/1597#issuecomment-338303735 https://api.github.com/repos/pydata/xarray/issues/1597 MDEyOklzc3VlQ29tbWVudDMzODMwMzczNQ== jhamman 2443309 2017-10-20T19:40:12Z 2017-10-20T19:40:47Z MEMBER

@nbren12 - can you add these methods to api.rst and add a note to whats-new (in addition to adding some docs to the reshaping page)?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add methods for combining variables of differing dimensionality 261131958
333254137 https://github.com/pydata/xarray/pull/1597#issuecomment-333254137 https://api.github.com/repos/pydata/xarray/issues/1597 MDEyOklzc3VlQ29tbWVudDMzMzI1NDEzNw== shoyer 1217238 2017-09-29T22:31:03Z 2017-09-29T22:31:03Z MEMBER

If we have a separate method for to_stacked_array(), we should have a separate method for unstacking, too.

I like DataArray.to_unstacked_dataset() as the complement to Dataset.to_stacked_array(). I agree that it should be a DataArray method for chain-ability.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add methods for combining variables of differing dimensionality 261131958
332950910 https://github.com/pydata/xarray/pull/1597#issuecomment-332950910 https://api.github.com/repos/pydata/xarray/issues/1597 MDEyOklzc3VlQ29tbWVudDMzMjk1MDkxMA== jhamman 2443309 2017-09-28T20:13:50Z 2017-09-28T20:13:50Z MEMBER

I want to let @shoyer and @rabernat weigh in on the API here. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add methods for combining variables of differing dimensionality 261131958

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);