issue_comments

Table actions

8 rows where author_association = "MEMBER", issue = 249584098 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

These facets timed out: issue

user 1

  • max-sixty · 8 ✖

author_association 1

  • MEMBER · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
455571902 https://github.com/pydata/xarray/pull/1507#issuecomment-455571902 https://api.github.com/repos/pydata/xarray/issues/1507 MDEyOklzc3VlQ29tbWVudDQ1NTU3MTkwMg== max-sixty 5635139 2019-01-18T14:52:09Z 2019-01-18T14:52:09Z MEMBER

Thanks @benbovy! 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Detailed report for testing.assert_equal and testing.assert_identical 249584098
454752304 https://github.com/pydata/xarray/pull/1507#issuecomment-454752304 https://api.github.com/repos/pydata/xarray/issues/1507 MDEyOklzc3VlQ29tbWVudDQ1NDc1MjMwNA== max-sixty 5635139 2019-01-16T11:52:45Z 2019-01-16T11:52:45Z MEMBER

This looks v good @benbovy!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Detailed report for testing.assert_equal and testing.assert_identical 249584098
454516512 https://github.com/pydata/xarray/pull/1507#issuecomment-454516512 https://api.github.com/repos/pydata/xarray/issues/1507 MDEyOklzc3VlQ29tbWVudDQ1NDUxNjUxMg== max-sixty 5635139 2019-01-15T19:19:53Z 2019-01-15T19:19:53Z MEMBER

I'm wondering which is the best among the options below:

TBH I think they're all good; I don't have a strong view. I'd low-confidence rank A->C->B 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Detailed report for testing.assert_equal and testing.assert_identical 249584098
454514749 https://github.com/pydata/xarray/pull/1507#issuecomment-454514749 https://api.github.com/repos/pydata/xarray/issues/1507 MDEyOklzc3VlQ29tbWVudDQ1NDUxNDc0OQ== max-sixty 5635139 2019-01-15T19:14:42Z 2019-01-15T19:14:42Z MEMBER

I think you should feel free to merge an MVP rather than perfecting, but check out https://docs.pytest.org/en/latest/example/simple.html#writing-well-integrated-assertion-helpers

I think that might be as simple as wrapping these in pytest.fail(...)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Detailed report for testing.assert_equal and testing.assert_identical 249584098
454503039 https://github.com/pydata/xarray/pull/1507#issuecomment-454503039 https://api.github.com/repos/pydata/xarray/issues/1507 MDEyOklzc3VlQ29tbWVudDQ1NDUwMzAzOQ== max-sixty 5635139 2019-01-15T18:39:53Z 2019-01-15T18:39:53Z MEMBER

If you want to add that example as a test, that could be a good way of documenting the function. But I don't think it's strictly needed

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Detailed report for testing.assert_equal and testing.assert_identical 249584098
454502075 https://github.com/pydata/xarray/pull/1507#issuecomment-454502075 https://api.github.com/repos/pydata/xarray/issues/1507 MDEyOklzc3VlQ29tbWVudDQ1NDUwMjA3NQ== max-sixty 5635139 2019-01-15T18:37:02Z 2019-01-15T18:37:02Z MEMBER

This looks amazing! I'm excited to use it. Thanks for finishing it up

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Detailed report for testing.assert_equal and testing.assert_identical 249584098
454501832 https://github.com/pydata/xarray/pull/1507#issuecomment-454501832 https://api.github.com/repos/pydata/xarray/issues/1507 MDEyOklzc3VlQ29tbWVudDQ1NDUwMTgzMg== max-sixty 5635139 2019-01-15T18:36:12Z 2019-01-15T18:36:12Z MEMBER

full comparison is done once again for formatting the report. I don't think there is an easy way to avoid that, but I don't think it's a big deal either.

i.e. there's a performance cost? Yeah that's def fine!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Detailed report for testing.assert_equal and testing.assert_identical 249584098
454173906 https://github.com/pydata/xarray/pull/1507#issuecomment-454173906 https://api.github.com/repos/pydata/xarray/issues/1507 MDEyOklzc3VlQ29tbWVudDQ1NDE3MzkwNg== max-sixty 5635139 2019-01-14T21:47:16Z 2019-01-14T21:47:16Z MEMBER

Any interest in pushing this over the line @benbovy ?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Detailed report for testing.assert_equal and testing.assert_identical 249584098

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);