issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 235761029 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Automate interpretation of _Unsigned attribute · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
318717311 https://github.com/pydata/xarray/pull/1453#issuecomment-318717311 https://api.github.com/repos/pydata/xarray/issues/1453 MDEyOklzc3VlQ29tbWVudDMxODcxNzMxMQ== shoyer 1217238 2017-07-28T17:39:11Z 2017-07-28T17:39:11Z MEMBER

Thanks @deeplycloudy !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Automate interpretation of _Unsigned attribute 235761029
316176226 https://github.com/pydata/xarray/pull/1453#issuecomment-316176226 https://api.github.com/repos/pydata/xarray/issues/1453 MDEyOklzc3VlQ29tbWVudDMxNjE3NjIyNg== shoyer 1217238 2017-07-18T19:44:48Z 2017-07-18T19:44:48Z MEMBER

Sounds good, I'll take another look shortly.

On Tue, Jul 18, 2017 at 10:46 AM, Joe Hamman notifications@github.com wrote:

@jhamman approved this pull request.

I think we're good to go here. @shoyer https://github.com/shoyer - I'll let you have the final review/merge.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/pull/1453#pullrequestreview-50689714, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKS1nsL9Rg-WevNBgY8i30AFt5SJGuBks5sPO-FgaJpZM4N5YIf . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Automate interpretation of _Unsigned attribute 235761029
308598903 https://github.com/pydata/xarray/pull/1453#issuecomment-308598903 https://api.github.com/repos/pydata/xarray/issues/1453 MDEyOklzc3VlQ29tbWVudDMwODU5ODkwMw== shoyer 1217238 2017-06-15T00:59:25Z 2017-06-15T00:59:25Z MEMBER

Instead of putting this alongside the mask_and_scale logic, can you make a separate class to do the dtype fixing in decode_cf_variable? Take a look at BoolTypeArray for an example.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Automate interpretation of _Unsigned attribute 235761029

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);