home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

where author_association = "MEMBER", issue = 230529125 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

These facets timed out: author_association, issue

user 1

  • shoyer · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
303270041 https://github.com/pydata/xarray/issues/1420#issuecomment-303270041 https://api.github.com/repos/pydata/xarray/issues/1420 MDEyOklzc3VlQ29tbWVudDMwMzI3MDA0MQ== shoyer 1217238 2017-05-23T02:09:15Z 2017-05-23T02:09:15Z MEMBER

If the new rule significantly better, then breaking changes are certainly possible (in a major release). But for bars should be high: it needs to be worth potential turmoil when users update their code.

For example, we could argue that x.equals(y) should be equivalent to bool((x == y).all()) (aside from NaNs), and note that in the docs.

I'm not sure what rule we could use for dropping scalar coordinates in particular. Adding an exception to the rules for only scalar coordinates would be a non-starter. The only alternative rule that seems at all sensible is that indexed coordinates only have the minimal set of coordinates (i.e., equivalent to calling .reset_coords(drop=True)).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  .equals() on a coordinate takes attributes into comparison 230529125
303246075 https://github.com/pydata/xarray/issues/1420#issuecomment-303246075 https://api.github.com/repos/pydata/xarray/issues/1420 MDEyOklzc3VlQ29tbWVudDMwMzI0NjA3NQ== shoyer 1217238 2017-05-22T23:20:09Z 2017-05-22T23:20:09Z MEMBER

Why is this point coordinate attached to every other coordinate then? In other words, why would da.coords['x'] contain some_attr as well?

The rule we currently use to propagate coordinates is to keep all other coordinates whose dimensions are contained in the dimensions of the coordinate, i.e., coordinates are presumed to describe not only the data-array, but an entire shared coordinate system. This is the same rule we use for choosing which coordinates to put on a DataArray when indexing a Dataset.

I'm certainly open to alternatives if we can find a simple way to express this.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  .equals() on a coordinate takes attributes into comparison 230529125
303241954 https://github.com/pydata/xarray/issues/1420#issuecomment-303241954 https://api.github.com/repos/pydata/xarray/issues/1420 MDEyOklzc3VlQ29tbWVudDMwMzI0MTk1NA== shoyer 1217238 2017-05-22T22:54:44Z 2017-05-22T22:54:44Z MEMBER

da['some_attr'] = 0 sets a non-dimension coordinate, not an attribute, so this is working as intended. Though I can see why we might want to change .equals() to ignore these: x.equals(y) is generally intended to be equivalent to (x == y).all().

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  .equals() on a coordinate takes attributes into comparison 230529125

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 4849.975ms · About: xarray-datasette