issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 219692578 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

issue 1

  • concat automagically outer-joins coordinates · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
499373615 https://github.com/pydata/xarray/issues/1354#issuecomment-499373615 https://api.github.com/repos/pydata/xarray/issues/1354 MDEyOklzc3VlQ29tbWVudDQ5OTM3MzYxNQ== shoyer 1217238 2019-06-06T06:57:50Z 2019-06-06T06:57:50Z MEMBER

Sure, we would welcome a PRs for this.

On Wed, Jun 5, 2019 at 11:33 PM Jonas notifications@github.com wrote:

Thanks for reminding me, stalte bot, this is still relevant to me.

I think your proposed solution @shoyer https://github.com/shoyer would solve this issue perfectly: expose align's join parameter in the concat function - and please also in open_mfdataset. Would you like a PR for this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/pydata/xarray/issues/1354?email_source=notifications&email_token=AAJJFVWVBBRU3HO3PZDGCO3PZCVUTA5CNFSM4DGS3QR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXB36MQ#issuecomment-499367730, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJJFVQ4YEERVTH2WFN77OLPZCVUTANCNFSM4DGS3QRQ . 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   concat automagically outer-joins coordinates 219692578
313163897 https://github.com/pydata/xarray/issues/1354#issuecomment-313163897 https://api.github.com/repos/pydata/xarray/issues/1354 MDEyOklzc3VlQ29tbWVudDMxMzE2Mzg5Nw== shoyer 1217238 2017-07-05T16:59:43Z 2017-07-05T16:59:43Z MEMBER

I think the right solution here is to relabel the coordinates on each of the datasets that you are concatenating. The alternative behavior here is xarray raising an error in the case of conflicting coordinate labels.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   concat automagically outer-joins coordinates 219692578
296111156 https://github.com/pydata/xarray/issues/1354#issuecomment-296111156 https://api.github.com/repos/pydata/xarray/issues/1354 MDEyOklzc3VlQ29tbWVudDI5NjExMTE1Ng== shoyer 1217238 2017-04-21T07:41:16Z 2017-04-21T07:41:16Z MEMBER

https://github.com/pydata/xarray/pull/1330 will help, in so far as it adds a join='exact' option that can disable automatic alignment. We would just need to make the join argument used internally in align inside xarray.concat part of the public API for concat.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   concat automagically outer-joins coordinates 219692578
292398769 https://github.com/pydata/xarray/issues/1354#issuecomment-292398769 https://api.github.com/repos/pydata/xarray/issues/1354 MDEyOklzc3VlQ29tbWVudDI5MjM5ODc2OQ== shoyer 1217238 2017-04-07T02:00:56Z 2017-04-07T02:00:56Z MEMBER

This only happens in concat.

merge, which happens automatically in many operations, e.g., to decide which coordinates propagate, has different behavior: it automatically drops conflicting coordinate values.

Anyways, I agree: we should try to make this more explicit. We might still keep the "magical" version of concat around, but we should certainly expose the fully explicit version as public API.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   concat automagically outer-joins coordinates 219692578

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);