issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 217287113 and user = 5356122 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • clarkfitzg · 3 ✖

issue 1

  • If join='exact', raise an error for non-aligned objects · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
302728009 https://github.com/pydata/xarray/pull/1330#issuecomment-302728009 https://api.github.com/repos/pydata/xarray/issues/1330 MDEyOklzc3VlQ29tbWVudDMwMjcyODAwOQ== clarkfitzg 5356122 2017-05-19T15:05:39Z 2017-05-19T15:05:39Z MEMBER

This has been sitting for a little while... @shoyer please don't let my comment keep you from merging- it was more to note that this introduces custom error types.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   If join='exact', raise an error for non-aligned objects 217287113
290578639 https://github.com/pydata/xarray/pull/1330#issuecomment-290578639 https://api.github.com/repos/pydata/xarray/issues/1330 MDEyOklzc3VlQ29tbWVudDI5MDU3ODYzOQ== clarkfitzg 5356122 2017-03-31T00:01:10Z 2017-03-31T00:01:10Z MEMBER

I'm thinking about some of the ones in alignment.py which are currently ValueError, for example: https://github.com/pydata/xarray/blob/master/xarray/core/alignment.py#L303

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   If join='exact', raise an error for non-aligned objects 217287113
290572513 https://github.com/pydata/xarray/pull/1330#issuecomment-290572513 https://api.github.com/repos/pydata/xarray/issues/1330 MDEyOklzc3VlQ29tbWVudDI5MDU3MjUxMw== clarkfitzg 5356122 2017-03-30T23:20:59Z 2017-03-30T23:20:59Z MEMBER

Does it seem useful to you?

Yes, it's a nice sanity check.

Does the name join='exact' make sense?

Yes.

Any thoughts on this feature?

Is it worth introducing custom exception types into xarray? Seems like ValueError would be fine here. Then users can write this without having to know we use our own special exceptions: try: xarray.merge([ds1, ds2], join='exact') except ValueError: ...

Otherwise you'll probably want to change some others to AlignmentError for consistency.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   If join='exact', raise an error for non-aligned objects 217287113

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);