issue_comments

Table actions

5 rows where author_association = "MEMBER", issue = 195832230 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 5 ✖

issue 1

  • Set a default _FillValue of NaN for float types · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
321886294 https://github.com/pydata/xarray/pull/1165#issuecomment-321886294 https://api.github.com/repos/pydata/xarray/issues/1165 MDEyOklzc3VlQ29tbWVudDMyMTg4NjI5NA== shoyer 1217238 2017-08-11T18:28:34Z 2017-08-11T18:28:34Z MEMBER

Is there a way to override this default behavior and write a netCDF file without including _FillValue in the metadata? For example, if one were adhering to a requested output format that does not include this?

This is a good question. I don't think so currently.

In principle we could use a entry in the encoding dict to signal this, i.e., {'_FillValue': None}.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set a default _FillValue of NaN for float types 195832230
268942718 https://github.com/pydata/xarray/pull/1165#issuecomment-268942718 https://api.github.com/repos/pydata/xarray/issues/1165 MDEyOklzc3VlQ29tbWVudDI2ODk0MjcxOA== shoyer 1217238 2016-12-23T05:29:16Z 2016-12-23T05:29:16Z MEMBER

@laliberte we missed giving your credit for this fix in "What's new". Any interest in putting together another quick PR adding "By Frederic Laliberte"?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set a default _FillValue of NaN for float types 195832230
267507053 https://github.com/pydata/xarray/pull/1165#issuecomment-267507053 https://api.github.com/repos/pydata/xarray/issues/1165 MDEyOklzc3VlQ29tbWVudDI2NzUwNzA1Mw== shoyer 1217238 2016-12-16T03:11:11Z 2016-12-16T03:11:11Z MEMBER

Thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set a default _FillValue of NaN for float types 195832230
267490261 https://github.com/pydata/xarray/pull/1165#issuecomment-267490261 https://api.github.com/repos/pydata/xarray/issues/1165 MDEyOklzc3VlQ29tbWVudDI2NzQ5MDI2MQ== shoyer 1217238 2016-12-16T01:03:32Z 2016-12-16T01:03:32Z MEMBER

OK, I'm fine with only doing this for real types. Complex types aren't really even valid in standard netCDF files (h5py uses a custom data type), so I'm not worried about compatibility with other tools.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set a default _FillValue of NaN for float types 195832230
267380946 https://github.com/pydata/xarray/pull/1165#issuecomment-267380946 https://api.github.com/repos/pydata/xarray/issues/1165 MDEyOklzc3VlQ29tbWVudDI2NzM4MDk0Ng== shoyer 1217238 2016-12-15T16:58:08Z 2016-12-15T16:58:08Z MEMBER

I agree that we just want to set _FillValue=NaN unilaterally for float arrays. This will make for slightly less tidy netCDF files, but we really don't want to be checking arrays for NaNs when we write them to disk, which would be untenable with dask.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Set a default _FillValue of NaN for float types 195832230

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);