issue_comments

Table actions

1 row where author_association = "MEMBER" and issue = 189415576 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Performance degradation: `DataArray` with `dtype=object` of `DataArray` gets very slow indexing · 1 ✖

author_association 1

  • MEMBER · 1 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
260683252 https://github.com/pydata/xarray/issues/1121#issuecomment-260683252 https://api.github.com/repos/pydata/xarray/issues/1121 MDEyOklzc3VlQ29tbWVudDI2MDY4MzI1Mg== shoyer 1217238 2016-11-15T16:05:20Z 2016-11-15T16:05:20Z MEMBER

Nesting xarray objects was not an intended use case, but I agree, this is ridiculously slow.

Looks the culprit is xarray.core.utils.to_0d_object_array: https://github.com/pydata/xarray/blob/d66f673ab25fe0fc0483bd5d67479fc94a14e46d/xarray/core/utils.py#L198-L212

Specifically, when value is an xarray.DataArray, these lines appear to trigger a iterating over every element of the DataArray, one by one:

result = np.empty((1,), dtype=object) result[:] = [value]

I'm definitely open to fixes here. Creating a NumPy object array can be very fussy -- NumPy tries way too hard to coerce dtypes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Performance degradation: `DataArray` with `dtype=object` of `DataArray` gets very slow indexing 189415576

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);