issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 189129954 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Creating a `Dataset` with a coordinate given by a `DataArray` may create an invalid dataset · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
325744538 https://github.com/pydata/xarray/issues/1120#issuecomment-325744538 https://api.github.com/repos/pydata/xarray/issues/1120 MDEyOklzc3VlQ29tbWVudDMyNTc0NDUzOA== shoyer 1217238 2017-08-29T17:58:26Z 2017-08-29T17:58:26Z MEMBER

@jhamman Probably in merge_core, which is used inside Dataset.__setitem__ as well as Dataset.__init__.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Creating a `Dataset` with a coordinate given by a `DataArray` may create an invalid dataset 189129954
325743300 https://github.com/pydata/xarray/issues/1120#issuecomment-325743300 https://api.github.com/repos/pydata/xarray/issues/1120 MDEyOklzc3VlQ29tbWVudDMyNTc0MzMwMA== jhamman 2443309 2017-08-29T17:53:51Z 2017-08-29T17:53:51Z MEMBER

@shoyer - do you think this fix belongs in merge_core or merge_data_and_coords? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Creating a `Dataset` with a coordinate given by a `DataArray` may create an invalid dataset 189129954
260396114 https://github.com/pydata/xarray/issues/1120#issuecomment-260396114 https://api.github.com/repos/pydata/xarray/issues/1120 MDEyOklzc3VlQ29tbWVudDI2MDM5NjExNA== shoyer 1217238 2016-11-14T17:07:10Z 2016-11-14T17:07:10Z MEMBER

I think this should raise an error, so I'm marking this as a bug. It's perfectly valid to construct a coordinate with arbitrary dimensions in xarray, but it should not be possible to use such variables as dimension names.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Creating a `Dataset` with a coordinate given by a `DataArray` may create an invalid dataset 189129954

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);