issue_comments

Table actions

7 rows where author_association = "MEMBER" and issue = 187625917 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 4

issue 1

  • WIP: New DataStore / Encoder / Decoder API for review · 7 ✖

author_association 1

  • MEMBER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
515848029 https://github.com/pydata/xarray/pull/1087#issuecomment-515848029 https://api.github.com/repos/pydata/xarray/issues/1087 MDEyOklzc3VlQ29tbWVudDUxNTg0ODAyOQ== shoyer 1217238 2019-07-29T05:17:46Z 2019-07-29T05:17:46Z MEMBER

This is gotten a little stale at this point. Coders did make it in, though we haven't moved over everything from conventions.py yet. This interface should also probably be reconciled with the use of CachingFileManager.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: New DataStore / Encoder / Decoder API for review 187625917
515846295 https://github.com/pydata/xarray/pull/1087#issuecomment-515846295 https://api.github.com/repos/pydata/xarray/issues/1087 MDEyOklzc3VlQ29tbWVudDUxNTg0NjI5NQ== jhamman 2443309 2019-07-29T05:07:32Z 2019-07-29T05:07:32Z MEMBER

@shoyer - since I've started work on a related subject in #3166, I'm wondering if you think this PR is capable of being revived? I think we'll have some time soon to pick this up in one form or another. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: New DataStore / Encoder / Decoder API for review 187625917
351931087 https://github.com/pydata/xarray/pull/1087#issuecomment-351931087 https://api.github.com/repos/pydata/xarray/issues/1087 MDEyOklzc3VlQ29tbWVudDM1MTkzMTA4Nw== alexamici 226037 2017-12-15T07:11:31Z 2017-12-15T07:11:31Z MEMBER

@shoyer regarding the xarray-grib-driver (not public yet, sorry) we have been working on the GRIB side lately and I didn't review this branch until today. Now we are coming back to the xarray side and I welcome the new "pluggability" of the encoding / decoding engine. Anyway since a lot of the coding work is already done by the ecCodes library my hope is that most of the complexity will stay outside of xarray anyway.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: New DataStore / Encoder / Decoder API for review 187625917
348382306 https://github.com/pydata/xarray/pull/1087#issuecomment-348382306 https://api.github.com/repos/pydata/xarray/issues/1087 MDEyOklzc3VlQ29tbWVudDM0ODM4MjMwNg== shoyer 1217238 2017-12-01T02:18:22Z 2017-12-01T02:18:22Z MEMBER

See https://github.com/pydata/xarray/pull/1752 for getting started on filters. I had a productive plane ride!

@alimanfoo thanks for the pointer to numcodecs. I'm sure that will come in handy eventually. Most of the "filters" xarray uses here are at a slightly higher level decoding/encoding metadata. The actual filters themselves are generally quite simple, e.g., just coercing a dtype, but there is lots of metadata to keep track of to know when they are appropriate to use.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: New DataStore / Encoder / Decoder API for review 187625917
348169779 https://github.com/pydata/xarray/pull/1087#issuecomment-348169779 https://api.github.com/repos/pydata/xarray/issues/1087 MDEyOklzc3VlQ29tbWVudDM0ODE2OTc3OQ== shoyer 1217238 2017-11-30T12:05:41Z 2017-11-30T12:05:41Z MEMBER

OK, I'm going to try to reboot this and finish it up in the form of an API that we'll be happy with going forward. I just discovered two more xarray backends over the past two days (in Unidata's Siphon and something @alexamici and colleagues are writing to reading GRIB files), so clearly the demand is here.

One additional change I'd like to make is try to rewrite the encoding/decoding functions for variables into a series of invertible coding filters that can potentially be chained together in a flexible way (this is somewhat inspired by zarr). This will allow different backends to mix/match filters as necessary, depending on their particular needs. I'll start on that in another PR.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: New DataStore / Encoder / Decoder API for review 187625917
347919138 https://github.com/pydata/xarray/pull/1087#issuecomment-347919138 https://api.github.com/repos/pydata/xarray/issues/1087 MDEyOklzc3VlQ29tbWVudDM0NzkxOTEzOA== rabernat 1197350 2017-11-29T16:38:33Z 2017-11-29T16:38:33Z MEMBER

Stephan this looks awesome! Should simplify the backends a lot!

I do worry that it will be painful to refactor the existing backends. But I guess that is the cost of progress.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: New DataStore / Encoder / Decoder API for review 187625917
347908842 https://github.com/pydata/xarray/pull/1087#issuecomment-347908842 https://api.github.com/repos/pydata/xarray/issues/1087 MDEyOklzc3VlQ29tbWVudDM0NzkwODg0Mg== shoyer 1217238 2017-11-29T16:07:53Z 2017-11-29T16:07:53Z MEMBER

CC @alexamici for interest in the backends refactor

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: New DataStore / Encoder / Decoder API for review 187625917

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);