issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 186868181 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 2 ✖

issue 1

  • DataArray.apply is missing · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
261316492 https://github.com/pydata/xarray/issues/1074#issuecomment-261316492 https://api.github.com/repos/pydata/xarray/issues/1074 MDEyOklzc3VlQ29tbWVudDI2MTMxNjQ5Mg== shoyer 1217238 2016-11-17T17:44:21Z 2016-11-17T17:44:21Z MEMBER

@burnpanck I missed your comments from a few weeks ago. Yes, please do make PRs to update the docs.

I am OK with adding DataArray.apply for consistency and discoverability, even if it's basically an alias of DataArray.pipe. And if we add a raw argument I suppose it should probably default to raw=False for both .apply methods.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.apply is missing 186868181
258327585 https://github.com/pydata/xarray/issues/1074#issuecomment-258327585 https://api.github.com/repos/pydata/xarray/issues/1074 MDEyOklzc3VlQ29tbWVudDI1ODMyNzU4NQ== shoyer 1217238 2016-11-04T02:10:04Z 2016-11-04T02:10:04Z MEMBER

We could try to get in a simple version of this before #964.

My only concern is that the functionality here is slightly different from Dataset.apply, which takes functions that map DataArray -> DataArray or DataArray -> numpy.ndarray.

For DataArray.apply, we really want something that maps numpy.ndarray -> numpy.ndarray, which is now inconsistent. I guess we could pass the original DataArray to the function, but we already have a .pipe method for that.

This is also a concern for #964, because any new xarray.apply function would have similar consistency issues with Dataset.apply.

Two possible solutions, neither of which is fully satisfying: - New keyword argument raw to Dataset.apply, defaulting to False. Works like the raw argument to DataFrame.apply. If raw=True, then Dataset.apply passes unlabeled arrays to the provided function, like DataArray.apply. This makes the difference a little less jarring. - Pick a new name for one of these uses of apply, e.g., apply_raw for this use case. xarray.apply_raw or DataArray.apply_raw is pretty verbose, though.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   DataArray.apply is missing 186868181

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);