issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 185441216 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Add remaining date units to conventions.py · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
256539119 https://github.com/pydata/xarray/issues/1062#issuecomment-256539119 https://api.github.com/repos/pydata/xarray/issues/1062 MDEyOklzc3VlQ29tbWVudDI1NjUzOTExOQ== jhamman 2443309 2016-10-27T03:42:14Z 2016-10-27T03:42:14Z MEMBER

@mcgibbon - I'm not sure what to do here then. There is a related discussion here that I think we should follow.

So I think we need a more informative error or to better use whatever error netcdf4 throws.

For the record, I never want a month to equal 30.42 days. I understand why UDUNITS did that (because units should vary with time) -- but they should have taken it up with those who decided on our calendar systems 😉. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add remaining date units to conventions.py 185441216
256417556 https://github.com/pydata/xarray/issues/1062#issuecomment-256417556 https://api.github.com/repos/pydata/xarray/issues/1062 MDEyOklzc3VlQ29tbWVudDI1NjQxNzU1Ng== jhamman 2443309 2016-10-26T17:19:44Z 2016-10-26T17:19:44Z MEMBER

@mcgibbon - I actually just ran into this today as well. I'd be happy to see something sensible added to our decoding. To start, why don't we only allow decoding of these units when the values are (like) integers. 16 years since 2000-01-01 is easy enough to decode but partial months/years can get tricky and error-prone since 10.84 months since 2016-01-01 requires us to make some decisions about the length of the month/year.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add remaining date units to conventions.py 185441216
256410357 https://github.com/pydata/xarray/issues/1062#issuecomment-256410357 https://api.github.com/repos/pydata/xarray/issues/1062 MDEyOklzc3VlQ29tbWVudDI1NjQxMDM1Nw== shoyer 1217238 2016-10-26T16:52:39Z 2016-10-26T16:52:39Z MEMBER

Indeed, NumPy converts these units inconsistently with Udunits:

```

np.timedelta64(1, 'Y').astype('timedelta64[D]') numpy.timedelta64(365,'D') ```

We currently convert all datetime arrays to ns resolution (for pandas compatibility), which means this would give possibly broken results.

But honestly, we haven't looked into this very much. If this would be a uniform improvement over the current state then it's worth considering.

CC @jhamman 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add remaining date units to conventions.py 185441216

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);