issue_comments

Table actions

where author_association = "MEMBER", issue = 179052741 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

user 1

  • max-sixty · 2 ✖

issue 1

  • WIP: Optional indexes (no more default coordinates given by range(n)) · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
261695720 https://github.com/pydata/xarray/pull/1017#issuecomment-261695720 https://api.github.com/repos/pydata/xarray/issues/1017 MDEyOklzc3VlQ29tbWVudDI2MTY5NTcyMA== max-sixty 5635139 2016-11-19T05:55:18Z 2016-11-19T05:55:18Z MEMBER

drop in pandas has a keyword argument errors='raise' (or errors='ignore') that lets it switch to work like discard. A separate discard method feels cleaner to me, but I can understand an argument for consistency with pandas. Thoughts?

In python sets have a remove and a discard - the first raises if not found, the second doesn't. Any thoughts on being consistent with that? Probably not worth the change cost tbh.

Overall no strong view; I'm probably a weak vote against adding discard without changing drop more thoroughly.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Optional indexes (no more default coordinates given by range(n)) 179052741
260783017 https://github.com/pydata/xarray/pull/1017#issuecomment-260783017 https://api.github.com/repos/pydata/xarray/issues/1017 MDEyOklzc3VlQ29tbWVudDI2MDc4MzAxNw== max-sixty 5635139 2016-11-15T21:58:04Z 2016-11-15T21:58:04Z MEMBER

I'm a +0.5 on @crusaderky 's (1). Although it's a list of Coordinates, so a bit odd to list something there that isn't one. I guess it could be renamed to Dimensions I'm a -0.7 on (2), because the behavior becomes less explicit

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   WIP: Optional indexes (no more default coordinates given by range(n)) 179052741

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);