issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 1695028906 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

issue 1

  • TypeError: 'NoneType' object is not callable when joining netCDF files. Works when ran interactively. · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1567037851 https://github.com/pydata/xarray/issues/7814#issuecomment-1567037851 https://api.github.com/repos/pydata/xarray/issues/7814 IC_kwDOAMm_X85dZxmb keewis 14808389 2023-05-29T11:53:37Z 2023-05-29T12:10:00Z MEMBER

Actually, it goes away with pip install jinja2. We don't use jinja2 at all, so either this is some kind of weird effect on garbage collection (a timing issue?), or dask is doing something differently as soon as jinja2 is available.

Edit: most likely this is a timing issue... the offending line tries to make use of the internal acquire function, which I think at that point has already been destroyed. To fix that, I think we need to somehow store a reference on the file manager?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   TypeError: 'NoneType' object is not callable when joining netCDF files. Works when ran interactively. 1695028906
1567025628 https://github.com/pydata/xarray/issues/7814#issuecomment-1567025628 https://api.github.com/repos/pydata/xarray/issues/7814 IC_kwDOAMm_X85dZunc keewis 14808389 2023-05-29T11:41:06Z 2023-05-29T11:56:20Z MEMBER

I can reproduce this locally: - download and unpack the files from https://github.com/pydata/xarray/issues/7814#issuecomment-1535168128 - use mamba create -n test python=3.11 xarray netcdf4 to create the environment (note: no dask) - use pip install "dask[array]" to install dask (does not pull distributed like the package from conda-forge) - put the code into a script and execute it

For reference, the full traceback is: pytb Exception ignored in: <function CachingFileManager.__del__ at 0x7fbdb237b430> Traceback (most recent call last): File "/home/jmagin/.local/opt/mambaforge/envs/test/lib/python3.9/site-packages/xarray/backends/file_manager.py", line 246, in __del__ TypeError: 'NoneType' object is not callable

As far as I can tell, this means we're using something from distributed with a broken fallback, since the error goes away as soon as I install distributed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   TypeError: 'NoneType' object is not callable when joining netCDF files. Works when ran interactively. 1695028906
1535776861 https://github.com/pydata/xarray/issues/7814#issuecomment-1535776861 https://api.github.com/repos/pydata/xarray/issues/7814 IC_kwDOAMm_X85bihhd kmuehlbauer 5821660 2023-05-05T06:31:20Z 2023-05-05T06:31:20Z MEMBER

@paul0207 Thanks for providing the datafiles. I can't reproduce on my machine. Please provide more information, the output of xr.show_versions() would help and a complete traceback of the error you are experiencing.

A complete list of installed Python Packages would be nice (eg. by pip list), too.

Another couple of questions to get some more insight:

  • Does this happen only with these special files, or do you experience this every time?
  • Does the problem persists when specifying engine="netcdf4" or engine="h5netcdf" in the call to open_mfdataset?
  • Does this also happen, if you open the files one-by-one (with xr.open_dataset) and combine the Datasets with xr.concat?
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   TypeError: 'NoneType' object is not callable when joining netCDF files. Works when ran interactively. 1695028906
1534000660 https://github.com/pydata/xarray/issues/7814#issuecomment-1534000660 https://api.github.com/repos/pydata/xarray/issues/7814 IC_kwDOAMm_X85bbv4U dcherian 2448579 2023-05-04T02:35:39Z 2023-05-04T02:35:39Z MEMBER

We;ll need a reproducible example

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   TypeError: 'NoneType' object is not callable when joining netCDF files. Works when ran interactively. 1695028906

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);