issue_comments

Table actions

8 rows where author_association = "MEMBER" and issue = 164948082 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

issue 1

  • Tweaks for opening datasets · 8 ✖

author_association 1

  • MEMBER · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
723660214 https://github.com/pydata/xarray/pull/895#issuecomment-723660214 https://api.github.com/repos/pydata/xarray/issues/895 MDEyOklzc3VlQ29tbWVudDcyMzY2MDIxNA== mathause 10194086 2020-11-08T20:18:01Z 2020-11-08T20:18:01Z MEMBER

I am closing this as stale. Half of this OR is implemented (#2732) the other half is #1754. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Tweaks for opening datasets 164948082
459775303 https://github.com/pydata/xarray/pull/895#issuecomment-459775303 https://api.github.com/repos/pydata/xarray/issues/895 MDEyOklzc3VlQ29tbWVudDQ1OTc3NTMwMw== max-sixty 5635139 2019-02-01T16:11:11Z 2019-02-01T16:11:11Z MEMBER

Great, @mathause - all yours, given no response from OP

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Tweaks for opening datasets 164948082
459629820 https://github.com/pydata/xarray/pull/895#issuecomment-459629820 https://api.github.com/repos/pydata/xarray/issues/895 MDEyOklzc3VlQ29tbWVudDQ1OTYyOTgyMA== mathause 10194086 2019-02-01T07:16:25Z 2019-02-01T07:16:56Z MEMBER

Once #2732 is merged (#2380) the first issue from the list should be resolved. I'd still be interested to get No 2 in.Maybe it would be better to open a new PR?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Tweaks for opening datasets 164948082
454164678 https://github.com/pydata/xarray/pull/895#issuecomment-454164678 https://api.github.com/repos/pydata/xarray/issues/895 MDEyOklzc3VlQ29tbWVudDQ1NDE2NDY3OA== max-sixty 5635139 2019-01-14T21:17:23Z 2019-01-14T21:17:23Z MEMBER

Would anyone like to take this up? I was going to close as stale, but it's fairly close!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Tweaks for opening datasets 164948082
315173422 https://github.com/pydata/xarray/pull/895#issuecomment-315173422 https://api.github.com/repos/pydata/xarray/issues/895 MDEyOklzc3VlQ29tbWVudDMxNTE3MzQyMg== jhamman 2443309 2017-07-13T19:07:44Z 2017-07-13T19:07:44Z MEMBER

@tsupinie - are you interested in finishing this up? Beyond a few changes requested by @shoyer, we just need some test coverage and a whatsnew entry. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Tweaks for opening datasets 164948082
232098656 https://github.com/pydata/xarray/pull/895#issuecomment-232098656 https://api.github.com/repos/pydata/xarray/issues/895 MDEyOklzc3VlQ29tbWVudDIzMjA5ODY1Ng== shoyer 1217238 2016-07-12T16:18:09Z 2016-07-12T16:18:09Z MEMBER

This looks like nice functionality!

The main thing it needs is tests. Let me know if you have any questions about how to go about writing those.

I also like the name keep_variables better than than only_variables.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Tweaks for opening datasets 164948082
232045709 https://github.com/pydata/xarray/pull/895#issuecomment-232045709 https://api.github.com/repos/pydata/xarray/issues/895 MDEyOklzc3VlQ29tbWVudDIzMjA0NTcwOQ== fmaussion 10050469 2016-07-12T13:24:06Z 2016-07-12T13:24:06Z MEMBER

Maybe keep_variables would be a more appropriate name? ('keep' vs 'drop').

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Tweaks for opening datasets 164948082
232002705 https://github.com/pydata/xarray/pull/895#issuecomment-232002705 https://api.github.com/repos/pydata/xarray/issues/895 MDEyOklzc3VlQ29tbWVudDIzMjAwMjcwNQ== mathause 10194086 2016-07-12T10:37:50Z 2016-07-12T10:37:50Z MEMBER

I like (2) - I once needed this functionality and had to infer the drop_vars.

``` def get_drop_vars(variables, ds):

if isinstance(variables, basestring):
    variables = [variables]
else:
    variables = list(variables)

# all variables
drop_var = set(ds.variables.keys())

# do not drop: coordinates, variables and time bounds
keep_var = ds.coords.keys() + variables + ['time_bounds', 'time_bnds']

drop_var.difference_update(keep_var)

return drop_var`

```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Tweaks for opening datasets 164948082

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);