issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 1575938277 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Dataset.where performances regression. · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1450712889 https://github.com/pydata/xarray/issues/7516#issuecomment-1450712889 https://api.github.com/repos/pydata/xarray/issues/7516 IC_kwDOAMm_X85WeB85 dcherian 2448579 2023-03-01T19:10:15Z 2023-03-01T19:10:15Z MEMBER

Yeah that was another change I guess. We could extract out the variable using .variable.

.where(sel2.variable.compute(), drop=True)

do your "_nadir" variables have smaller chunk sizes or are slower to read for some reason?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.where performances regression. 1575938277
1449085012 https://github.com/pydata/xarray/issues/7516#issuecomment-1449085012 https://api.github.com/repos/pydata/xarray/issues/7516 IC_kwDOAMm_X85WX0hU dcherian 2448579 2023-02-28T23:30:59Z 2023-02-28T23:30:59Z MEMBER

Does sel.compute() not finish?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.where performances regression. 1575938277
1447565936 https://github.com/pydata/xarray/issues/7516#issuecomment-1447565936 https://api.github.com/repos/pydata/xarray/issues/7516 IC_kwDOAMm_X85WSBpw dcherian 2448579 2023-02-28T04:41:03Z 2023-02-28T04:41:03Z MEMBER

The old code had: nonzeros = zip(clipcond.dims, np.nonzero(clipcond.values))

This loaded the array once and then passed numpy values to the indexing code.

Now, the dask array is passed to the indexing code and is computed many times . #5873 raises an error saying boolean indexing with dask arrays is not allowed.

For here just do ds.where(sel.compute(), drop=True). It's identical to what was happening earlier.

I think we should close this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Dataset.where performances regression. 1575938277

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);