issue_comments

Table actions

9 rows where author_association = "MEMBER" and issue = 1533980729 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Preserve formatting of reference time units under pandas 2.0.0 · 9 ✖

author_association 1

  • MEMBER · 9 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1492956264 https://github.com/pydata/xarray/pull/7441#issuecomment-1492956264 https://api.github.com/repos/pydata/xarray/issues/7441 IC_kwDOAMm_X85Y_LRo spencerkclark 6628425 2023-04-01T12:22:31Z 2023-04-01T12:22:31Z MEMBER

Thanks for cleaning up the merge error I must have introduced; I agree this should be ready to go.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Preserve formatting of reference time units under pandas 2.0.0 1533980729
1492947179 https://github.com/pydata/xarray/pull/7441#issuecomment-1492947179 https://api.github.com/repos/pydata/xarray/issues/7441 IC_kwDOAMm_X85Y_JDr keewis 14808389 2023-04-01T11:47:07Z 2023-04-01T11:47:07Z MEMBER

the commit with my fix seems to have passed all CI (although using isoformat(sep=" ") is much better), and the upstream-dev CI only failed with unrelated issues, so once CI passes I think we can finally merge this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Preserve formatting of reference time units under pandas 2.0.0 1533980729
1492724527 https://github.com/pydata/xarray/pull/7441#issuecomment-1492724527 https://api.github.com/repos/pydata/xarray/issues/7441 IC_kwDOAMm_X85Y-Ssv spencerkclark 6628425 2023-03-31T23:41:20Z 2023-03-31T23:41:20Z MEMBER

Thanks @keewis for fixing this upstream (https://github.com/pandas-dev/pandas/pull/52220)!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Preserve formatting of reference time units under pandas 2.0.0 1533980729
1465318583 https://github.com/pydata/xarray/pull/7441#issuecomment-1465318583 https://api.github.com/repos/pydata/xarray/issues/7441 IC_kwDOAMm_X85XVvy3 spencerkclark 6628425 2023-03-12T22:37:20Z 2023-03-12T22:37:20Z MEMBER

Still mulling this over a bit, but one other thing that occurs to me is that if we go with a strftime solution we should be careful (if it exists) to preserve any sub-second information of the Timestamp as well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Preserve formatting of reference time units under pandas 2.0.0 1533980729
1460037064 https://github.com/pydata/xarray/pull/7441#issuecomment-1460037064 https://api.github.com/repos/pydata/xarray/issues/7441 IC_kwDOAMm_X85XBmXI spencerkclark 6628425 2023-03-08T11:46:04Z 2023-03-08T11:46:04Z MEMBER

Hmm I guess I should have run the tests before saying anything. We could probably work around the NaT issue fairly easily, but I forgot about timezones. The ability to include a colon in the UTC offset, which we expect in the failing test, with strftime was only recently added to Python (https://github.com/python/cpython/pull/95983), which makes things a little messier. I'll think about this a little more.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Preserve formatting of reference time units under pandas 2.0.0 1533980729
1459255349 https://github.com/pydata/xarray/pull/7441#issuecomment-1459255349 https://api.github.com/repos/pydata/xarray/issues/7441 IC_kwDOAMm_X85W-ng1 spencerkclark 6628425 2023-03-08T03:08:31Z 2023-03-08T03:08:31Z MEMBER

Thanks @keewis--great suggestion--I think this should be ready for review now too!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Preserve formatting of reference time units under pandas 2.0.0 1533980729
1397354953 https://github.com/pydata/xarray/pull/7441#issuecomment-1397354953 https://api.github.com/repos/pydata/xarray/issues/7441 IC_kwDOAMm_X85TSfHJ spencerkclark 6628425 2023-01-19T17:33:16Z 2023-01-19T17:33:16Z MEMBER

Issue reported here: https://github.com/pandas-dev/pandas/issues/50867. Thanks again for noting that @keewis. I was too narrowly focused on fixing this in xarray.

We may still want to be careful about non-nanosecond-precision Timestamp objects leaking into our code for the time being, but that's a different conversation.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Preserve formatting of reference time units under pandas 2.0.0 1533980729
1397286186 https://github.com/pydata/xarray/pull/7441#issuecomment-1397286186 https://api.github.com/repos/pydata/xarray/issues/7441 IC_kwDOAMm_X85TSOUq spencerkclark 6628425 2023-01-19T16:45:24Z 2023-01-19T17:16:31Z MEMBER

Thanks @keewis.

I think this is a bug in pandas: pd.Timestamp("1-01-01 00:00:00") returns a date in 2001.

I suspect this may be related to the comment here.

In any case, t.isoformat(sep=" ") should return the year with 4 digits so maybe we should use that instead? (once again, it doesn't, but that I think is also a bug, maybe the same one?)

Though indeed the isoformat behavior is definitely a bug and it would be fair to at least expect this kind of roundtrip to hold, but it doesn't: ```

import pandas as pd pd.Timestamp(str(pd.Timestamp("0001-01-01"))) Timestamp('2001-01-01 00:00:00') ```

I can report that to pandas. It's not necessarily surprising considering that it previously was not possible to write pd.Timestamp("0001-01-01"). 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Preserve formatting of reference time units under pandas 2.0.0 1533980729
1397256170 https://github.com/pydata/xarray/pull/7441#issuecomment-1397256170 https://api.github.com/repos/pydata/xarray/issues/7441 IC_kwDOAMm_X85TSG_q keewis 14808389 2023-01-19T16:28:11Z 2023-01-19T16:28:11Z MEMBER

I think this is a bug in pandas: pd.Timestamp("1-01-01 00:00:00") returns a date in 2001.

In any case, t.isoformat(sep=" ") should return the year with 4 digits so maybe we should use that instead? (once again, it doesn't, but that I think is also a bug, maybe the same one?)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Preserve formatting of reference time units under pandas 2.0.0 1533980729

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);