issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 148765426 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • keep_attrs for Dataset.resample and DataArray.resample · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
210925025 https://github.com/pydata/xarray/issues/825#issuecomment-210925025 https://api.github.com/repos/pydata/xarray/issues/825 MDEyOklzc3VlQ29tbWVudDIxMDkyNTAyNQ== shoyer 1217238 2016-04-16T23:46:26Z 2016-04-16T23:46:26Z MEMBER

I think it's best to make first and last consist with the other resample methods rather than making them inconsistent. Feel free to consider that a bug.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   keep_attrs for Dataset.resample and DataArray.resample 148765426
210697873 https://github.com/pydata/xarray/issues/825#issuecomment-210697873 https://api.github.com/repos/pydata/xarray/issues/825 MDEyOklzc3VlQ29tbWVudDIxMDY5Nzg3Mw== shoyer 1217238 2016-04-16T00:34:42Z 2016-04-16T00:34:42Z MEMBER

This keeps coming up, but I don't know what the obvious solution is.

We certainly could add an option that would change the default for keep_attrs to True for every operation. Then you could write xr.set_options(keep_attrs=True) at the top of your scripts to guarantee that metadata is preserved.

When merging datasets, concat and merge currently just take attributes from the first argument. We could imagine adding options for more sophisticated attribute merge strategies (e.g., join all non-conflicting attributes).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   keep_attrs for Dataset.resample and DataArray.resample 148765426
210697338 https://github.com/pydata/xarray/issues/825#issuecomment-210697338 https://api.github.com/repos/pydata/xarray/issues/825 MDEyOklzc3VlQ29tbWVudDIxMDY5NzMzOA== jhamman 2443309 2016-04-16T00:29:23Z 2016-04-16T00:29:23Z MEMBER

The attrs attribute on the Dataset and DataArray is just a dictionary so one can just assign directly.

Python da_resampled = da.resample(...) da_resampled.attrs = da.attrs

Or you could just copy them over one by one. Either way, I don't think we need much more of a utility than that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   keep_attrs for Dataset.resample and DataArray.resample 148765426
210671507 https://github.com/pydata/xarray/issues/825#issuecomment-210671507 https://api.github.com/repos/pydata/xarray/issues/825 MDEyOklzc3VlQ29tbWVudDIxMDY3MTUwNw== jhamman 2443309 2016-04-15T22:37:23Z 2016-04-15T22:37:23Z MEMBER

@mcgibbon - yes, we can add a keep_attrs keyword argument to resample. Would you be interested in putting together a PR for that feature?

@pwolfram - we had a lot of discussion early on about what to do with attributes after an object had been manipulated. The consensus was to force the user to maintain the attributes to the extent he/she desired. xarray doesn't have any notion of units (one example of an attribute) and this led us to trend away from religiously keeping passing attributes on to new objects.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   keep_attrs for Dataset.resample and DataArray.resample 148765426

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);