issue_comments

Table actions

3 rows where author_association = "MEMBER" and issue = 148757289 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Disable lock=True in open_mfdataset when reading netCDF3 files · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
458809101 https://github.com/pydata/xarray/issues/824#issuecomment-458809101 https://api.github.com/repos/pydata/xarray/issues/824 MDEyOklzc3VlQ29tbWVudDQ1ODgwOTEwMQ== shoyer 1217238 2019-01-30T04:37:36Z 2019-01-30T04:37:50Z MEMBER

Yes it was

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Disable lock=True in open_mfdataset when reading netCDF3 files 148757289
458808676 https://github.com/pydata/xarray/issues/824#issuecomment-458808676 https://api.github.com/repos/pydata/xarray/issues/824 MDEyOklzc3VlQ29tbWVudDQ1ODgwODY3Ng== jhamman 2443309 2019-01-30T04:35:02Z 2019-01-30T04:35:02Z MEMBER

@shoyer - this was addressed in the backend refactor this summer, no?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Disable lock=True in open_mfdataset when reading netCDF3 files 148757289
210633360 https://github.com/pydata/xarray/issues/824#issuecomment-210633360 https://api.github.com/repos/pydata/xarray/issues/824 MDEyOklzc3VlQ29tbWVudDIxMDYzMzM2MA== shoyer 1217238 2016-04-15T20:33:29Z 2016-04-15T20:33:29Z MEMBER

The issues with multithreading without a lock come up only when using netCDF4/HDF5. With netCDF3, you don't need the lock when reading data.

I don't like changing to lock=False in all circumstances, because that will lead to segfaults and segfaults make for a bad new user experience! Instead, lock=None should do something smart.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Disable lock=True in open_mfdataset when reading netCDF3 files 148757289

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);