home / github

Menu
  • GraphQL API
  • Search all tables

issue_comments

Table actions
  • GraphQL API for issue_comments

11 rows where author_association = "MEMBER" and issue = 145243134 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

  • shoyer 6
  • max-sixty 3
  • fmaussion 2

issue 1

  • Add drop=True option for where on Dataset and DataArray · 11 ✖

author_association 1

  • MEMBER · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
207890803 https://github.com/pydata/xarray/pull/815#issuecomment-207890803 https://api.github.com/repos/pydata/xarray/issues/815 MDEyOklzc3VlQ29tbWVudDIwNzg5MDgwMw== shoyer 1217238 2016-04-10T00:33:25Z 2016-04-10T00:33:25Z MEMBER

Thanks @pwolfram !

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add drop=True option for where on Dataset and DataArray 145243134
205406043 https://github.com/pydata/xarray/pull/815#issuecomment-205406043 https://api.github.com/repos/pydata/xarray/issues/815 MDEyOklzc3VlQ29tbWVudDIwNTQwNjA0Mw== shoyer 1217238 2016-04-04T17:28:12Z 2016-04-04T17:28:12Z MEMBER

looks good to me other than a few nits

Please also add a release note crediting yourself!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add drop=True option for where on Dataset and DataArray 145243134
204564456 https://github.com/pydata/xarray/pull/815#issuecomment-204564456 https://api.github.com/repos/pydata/xarray/issues/815 MDEyOklzc3VlQ29tbWVudDIwNDU2NDQ1Ng== shoyer 1217238 2016-04-01T21:00:31Z 2016-04-01T21:00:31Z MEMBER

+1 for drop=True

On Fri, Apr 1, 2016 at 1:59 PM, Phillip Wolfram notifications@github.com wrote:

@shoyer https://github.com/shoyer et al, I think @MaximilianR https://github.com/MaximilianR's suggestion makes sense. This would reduce the amount of code that has to be accounted for too and would be cleaner. Essentially have this method be called via array.where(mask, drop=True) instead of array.sel_where(mask).

All feedback on this proposal welcome.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/pydata/xarray/pull/815#issuecomment-204564228

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add drop=True option for where on Dataset and DataArray 145243134
204561434 https://github.com/pydata/xarray/pull/815#issuecomment-204561434 https://api.github.com/repos/pydata/xarray/issues/815 MDEyOklzc3VlQ29tbWVudDIwNDU2MTQzNA== max-sixty 5635139 2016-04-01T20:46:56Z 2016-04-01T20:47:21Z MEMBER

FWIW I'm not a fan of the sel_where name, sel is otherwise associated with labels, and this takes bools. Have you thought about including this in where, with a kwarg such as drop?

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add drop=True option for where on Dataset and DataArray 145243134
204561404 https://github.com/pydata/xarray/pull/815#issuecomment-204561404 https://api.github.com/repos/pydata/xarray/issues/815 MDEyOklzc3VlQ29tbWVudDIwNDU2MTQwNA== max-sixty 5635139 2016-04-01T20:46:49Z 2016-04-01T20:46:49Z MEMBER

Right, I see. I think it's equivalent only to a pandas slice on Series, rather than a DataFrame.

``` python In [71]: series = pd.Series(range(10))

In [72]: series[series>5] Out[72]: 6 6 7 7 8 8 9 9 dtype: int64

...same as sel_where

In [78]: df =pd.DataFrame(pd.np.arange(40).reshape(4,10))

In [79]: df[(df>11) & (df < 28)] Out[79]: 0 1 2 3 4 5 6 7 8 9 0 NaN NaN NaN NaN NaN NaN NaN NaN NaN NaN 1 NaN NaN 12 13 14 15 16 17 18 19 2 20 21 22 23 24 25 26 27 NaN NaN 3 NaN NaN NaN NaN NaN NaN NaN NaN NaN NaN

...same as where

```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add drop=True option for where on Dataset and DataArray 145243134
204527062 https://github.com/pydata/xarray/pull/815#issuecomment-204527062 https://api.github.com/repos/pydata/xarray/issues/815 MDEyOklzc3VlQ29tbWVudDIwNDUyNzA2Mg== shoyer 1217238 2016-04-01T19:08:46Z 2016-04-01T19:10:15Z MEMBER

@MaximilianR In this example I used where to produce a map:

```

ds.states.where(ds.states == state_ids['California']).plot() ```

If I used sel_where, the plot would be automatically trimmed. That's the main usecase here. I don't think there is an equivalent shortcut in pandas.

@fmaussion that's correct that you cannot do lazy computation with the result of nonzero on a dask array. However, computing nonzero itself could be an expensive operation if the mask is large, and we could do that with dask.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add drop=True option for where on Dataset and DataArray 145243134
204525952 https://github.com/pydata/xarray/pull/815#issuecomment-204525952 https://api.github.com/repos/pydata/xarray/issues/815 MDEyOklzc3VlQ29tbWVudDIwNDUyNTk1Mg== fmaussion 10050469 2016-04-01T19:03:47Z 2016-04-01T19:03:47Z MEMBER

@pwolfram thanks. It's hard to tell form the print, but from the dimensions of the output it looks fine. The real use case would if you have (x,y,time), you would like to sel_where based on x,y only (for example a landmask or something).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add drop=True option for where on Dataset and DataArray 145243134
204525759 https://github.com/pydata/xarray/pull/815#issuecomment-204525759 https://api.github.com/repos/pydata/xarray/issues/815 MDEyOklzc3VlQ29tbWVudDIwNDUyNTc1OQ== max-sixty 5635139 2016-04-01T19:02:55Z 2016-04-01T19:02:55Z MEMBER

Forgive me if this is naive - is this equivalent to a pandas slice?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add drop=True option for where on Dataset and DataArray 145243134
204519675 https://github.com/pydata/xarray/pull/815#issuecomment-204519675 https://api.github.com/repos/pydata/xarray/issues/815 MDEyOklzc3VlQ29tbWVudDIwNDUxOTY3NQ== shoyer 1217238 2016-04-01T18:50:41Z 2016-04-01T18:50:57Z MEMBER

At some point it might be useful to be able to use dask to compute the mask (with mask.data.nonzero()), so I made an issue for that: https://github.com/dask/dask/issues/1076

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add drop=True option for where on Dataset and DataArray 145243134
204501428 https://github.com/pydata/xarray/pull/815#issuecomment-204501428 https://api.github.com/repos/pydata/xarray/issues/815 MDEyOklzc3VlQ29tbWVudDIwNDUwMTQyOA== fmaussion 10050469 2016-04-01T18:21:04Z 2016-04-01T18:21:04Z MEMBER

This is very cool! Would it also work in that case?

python a = xr.DataArray(np.arange(5**3).reshape(5, 5, 5), dims=('x', 'y', 'z')) mask = xr.DataArray(np.arange(5**2).reshape(5, 5), dims=('x', 'y')) a.sel_where(np.logical_and(mask > 6, mask < 18))

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add drop=True option for where on Dataset and DataArray 145243134
204499751 https://github.com/pydata/xarray/pull/815#issuecomment-204499751 https://api.github.com/repos/pydata/xarray/issues/815 MDEyOklzc3VlQ29tbWVudDIwNDQ5OTc1MQ== shoyer 1217238 2016-04-01T18:14:42Z 2016-04-01T18:14:42Z MEMBER

Yes, expanding the section on "where" seems like the right place to put this.

On Fri, Apr 1, 2016 at 11:08 AM, Phillip Wolfram notifications@github.com wrote:

@shoyer https://github.com/shoyer, I haven't added any specific documentation. Would you recommend doing so and if so, should this go near here https://github.com/pydata/xarray/blame/master/doc/indexing.rst#L265?

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/pydata/xarray/pull/815#issuecomment-204498369

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  Add drop=True option for where on Dataset and DataArray 145243134

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 18.039ms · About: xarray-datasette
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows