issue_comments

Table actions

6 rows where author_association = "MEMBER" and issue = 1440354343 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 3

issue 1

  • `keep_attrs` for pad · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1346786560 https://github.com/pydata/xarray/pull/7267#issuecomment-1346786560 https://api.github.com/repos/pydata/xarray/issues/7267 IC_kwDOAMm_X85QRlUA keewis 14808389 2022-12-12T15:59:33Z 2022-12-12T15:59:33Z MEMBER

the mypy failures look unrelated, so let's merge

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `keep_attrs` for pad 1440354343
1341655437 https://github.com/pydata/xarray/pull/7267#issuecomment-1341655437 https://api.github.com/repos/pydata/xarray/issues/7267 IC_kwDOAMm_X85P-AmN dcherian 2448579 2022-12-07T22:07:19Z 2022-12-07T22:07:19Z MEMBER

@keewis shall we merge?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `keep_attrs` for pad 1440354343
1317514344 https://github.com/pydata/xarray/pull/7267#issuecomment-1317514344 https://api.github.com/repos/pydata/xarray/issues/7267 IC_kwDOAMm_X85Oh6xo dcherian 2448579 2022-11-16T18:53:16Z 2022-11-16T18:53:16Z MEMBER

so I wonder if we should do this in one (slightly big) PR? But then we might need a deprecation cycle?

I think we decided to avoid the deprecation cycle for keep_attrs changes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `keep_attrs` for pad 1440354343
1307873863 https://github.com/pydata/xarray/pull/7267#issuecomment-1307873863 https://api.github.com/repos/pydata/xarray/issues/7267 IC_kwDOAMm_X85N9JJH keewis 14808389 2022-11-08T21:50:46Z 2022-11-08T21:50:46Z MEMBER

I'm always setting xr.set_options(keep_attrs=True) after importing xarray, anyways, so :+1: from me.

However, this would be a change in policy (#3891) so I wonder if we should do this in one (slightly big) PR? But then we might need a deprecation cycle?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `keep_attrs` for pad 1440354343
1307719581 https://github.com/pydata/xarray/pull/7267#issuecomment-1307719581 https://api.github.com/repos/pydata/xarray/issues/7267 IC_kwDOAMm_X85N8jed max-sixty 5635139 2022-11-08T19:21:58Z 2022-11-08T19:21:58Z MEMBER

LGTM. Could consider having it be True by default since most attrs will still make sense.

+1 to both the specific point and generally moving in this direction...

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   `keep_attrs` for pad 1440354343
1307417740 https://github.com/pydata/xarray/pull/7267#issuecomment-1307417740 https://api.github.com/repos/pydata/xarray/issues/7267 IC_kwDOAMm_X85N7ZyM keewis 14808389 2022-11-08T15:39:46Z 2022-11-08T16:49:53Z MEMBER

wow, it seems now the mypy CI fails with a segfault. @headtr1ck, @Illviljan, @max-sixty: should we pin mypy to mypy<0.990 until we (or rather: any of you?) can figure out what is going wrong with that?

 
{
    "total_count": 3,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 1
}
   `keep_attrs` for pad 1440354343

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);