issue_comments

Table actions

5 rows where author_association = "MEMBER" and issue = 1412019155 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Lazy Imports · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1317819272 https://github.com/pydata/xarray/pull/7179#issuecomment-1317819272 https://api.github.com/repos/pydata/xarray/issues/7179 IC_kwDOAMm_X85OjFOI dcherian 2448579 2022-11-16T23:32:21Z 2022-11-16T23:32:21Z MEMBER

Turns out it is a pyodide bug with how they hook in to importlib

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy Imports 1412019155
1317583451 https://github.com/pydata/xarray/pull/7179#issuecomment-1317583451 https://api.github.com/repos/pydata/xarray/issues/7179 IC_kwDOAMm_X85OiLpb dcherian 2448579 2022-11-16T19:49:22Z 2022-11-16T19:50:02Z MEMBER

FYI I'm getting this error when trying to update the version in pyodide: https://app.circleci.com/pipelines/github/pyodide/pyodide/5016/workflows/e2cc0865-a91d-4cdb-8dbc-dfaeeb522c5f/jobs/60731

```python JavascriptException message: Traceback (most recent call last): File "/lib/python3.10/asyncio/futures.py", line 201, in result raise self.exception File "/lib/python3.10/asyncio/tasks.py", line 232, in __step result = coro.send(None) File "/lib/python3.10/_pyodide/_base.py", line 531, in eval_code_async await CodeRunner( File "/lib/python3.10/_pyodide/_base.py", line 357, in run_async coroutine = eval(self.code, globals, locals) File "<exec>", line 1, in <module> File "/lib/python3.10/site-packages/xarray/__init__.py", line 1, in <module> from . import testing, tutorial File "/lib/python3.10/site-packages/xarray/tutorial.py", line 17, in <module> from .backends.api import open_dataset as _open_dataset File "/lib/python3.10/site-packages/xarray/backends/__init__.py", line 16, in <module> from .scipy import ScipyBackendEntrypoint, ScipyDataStore File "/lib/python3.10/site-packages/xarray/backends/scipy_.py", line 239, in <module> class ScipyBackendEntrypoint(BackendEntrypoint): File "/lib/python3.10/site-packages/xarray/backends/scipy_.py", line 260, in ScipyBackendEntrypoint available = module_available("scipy") File "/lib/python3.10/site-packages/xarray/core/utils.py", line 1009, in module_available return importlib.util.find_spec(module) is not None File "/lib/python3.10/importlib/util.py", line 103, in find_spec return _find_spec(fullname, parent_path) File "/lib/python3.10/_pyodide/_importhook.py", line 226, in find_spec raise ModuleNotFoundError( ModuleNotFoundError: The module 'scipy' is included in the Pyodide distribution, but it is not installed. You can install it by calling: await micropip.install("scipy") in Python or await pyodide.loadPackage("scipy") in JavaScript. See https://pyodide.org/en/stable/usage/loading-packages.html for more details.

````

this seems like a bug in importlib

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy Imports 1412019155
1295196783 https://github.com/pydata/xarray/pull/7179#issuecomment-1295196783 https://api.github.com/repos/pydata/xarray/issues/7179 IC_kwDOAMm_X85NMyJv dcherian 2448579 2022-10-28T16:25:19Z 2022-10-28T16:25:19Z MEMBER

Thanks @headtr1ck great PR!

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy Imports 1412019155
1282995923 https://github.com/pydata/xarray/pull/7179#issuecomment-1282995923 https://api.github.com/repos/pydata/xarray/issues/7179 IC_kwDOAMm_X85MePbT max-sixty 5635139 2022-10-18T20:58:04Z 2022-10-18T20:58:04Z MEMBER

Do you think there's a risk something gets added back by mistake?

A galaxy brain idea is to have a lint in pre-commit which looks for ^import (foo|bar) for the libraries we should be lazy loading. Not fool proof. Or something to measure import time so we can see if it rises again.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy Imports 1412019155
1281527397 https://github.com/pydata/xarray/pull/7179#issuecomment-1281527397 https://api.github.com/repos/pydata/xarray/issues/7179 IC_kwDOAMm_X85MYo5l max-sixty 5635139 2022-10-17T21:36:58Z 2022-10-17T21:36:58Z MEMBER

Very nice @headtr1ck !

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Lazy Imports 1412019155

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);