issue_comments

Table actions

6 rows where author_association = "MEMBER" and issue = 1391699976 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • .sel return errors when using floats for no apparent reason · 6 ✖

author_association 1

  • MEMBER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1266073388 https://github.com/pydata/xarray/issues/7108#issuecomment-1266073388 https://api.github.com/repos/pydata/xarray/issues/7108 IC_kwDOAMm_X85Ldr8s benbovy 4160723 2022-10-03T21:28:43Z 2022-10-03T21:28:43Z MEMBER

I suppose re-projecting it on a 0-360 would be the only way around this specific issue.

A custom Xarray index would help, e.g., PeriodicBoundaryIndex (#7031) or a GeographicIndex leveraging libraries like S2Geometry or H3. 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .sel return errors when using floats for no apparent reason 1391699976
1265012286 https://github.com/pydata/xarray/issues/7108#issuecomment-1265012286 https://api.github.com/repos/pydata/xarray/issues/7108 IC_kwDOAMm_X85LZo4- benbovy 4160723 2022-10-03T06:57:17Z 2022-10-03T06:57:17Z MEMBER

TBH, I had to do some research before figuring out what was going on :).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .sel return errors when using floats for no apparent reason 1391699976
1263807395 https://github.com/pydata/xarray/issues/7108#issuecomment-1263807395 https://api.github.com/repos/pydata/xarray/issues/7108 IC_kwDOAMm_X85LVCuj max-sixty 5635139 2022-09-30T16:59:06Z 2022-09-30T16:59:06Z MEMBER

Float indexes are often a source of pain, unfortunately!

...also for my ability to know what's going on, apparently :). Thanks a lot @benbovy .

Yes, that would be great to raise a more informative error. We could also put an issue in upstream if pandas itself has the same issue.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .sel return errors when using floats for no apparent reason 1391699976
1263548977 https://github.com/pydata/xarray/issues/7108#issuecomment-1263548977 https://api.github.com/repos/pydata/xarray/issues/7108 IC_kwDOAMm_X85LUDox benbovy 4160723 2022-09-30T13:03:26Z 2022-09-30T13:03:26Z MEMBER

It looks like the error is because of the non-monotonic coordinate labels for the "lon" coordinate in nc_bug rather than a float precision issue. The "lon" coordinate seems monotonic for nc_ok so it works.

When a slice is given as indexer, Xarray internally calls pandas.Index.slice_indexer(), which requires that the index must be ordered and unique (docs). Unfortunately, Pandas does not mention it while it raises a KeyError. Should we first check the index in Xarray and raise a nicer error message if it is not unique / ordered?

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .sel return errors when using floats for no apparent reason 1391699976
1263070017 https://github.com/pydata/xarray/issues/7108#issuecomment-1263070017 https://api.github.com/repos/pydata/xarray/issues/7108 IC_kwDOAMm_X85LSOtB max-sixty 5635139 2022-09-30T03:49:51Z 2022-09-30T03:49:51Z MEMBER

Ah, right. Does it select a value with just nc_bug.sel(lon = 161.001, tolerance=0.1)? Because the lon value which that selects is probably the value you need to use in the slice.

Float indexes are often a source of pain, unfortunately!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .sel return errors when using floats for no apparent reason 1391699976
1263040310 https://github.com/pydata/xarray/issues/7108#issuecomment-1263040310 https://api.github.com/repos/pydata/xarray/issues/7108 IC_kwDOAMm_X85LSHc2 max-sixty 5635139 2022-09-30T02:47:13Z 2022-09-30T02:47:13Z MEMBER

Generally this is because the floats aren't exactly the same value — does passing tolerance=0.1 help?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   .sel return errors when using floats for no apparent reason 1391699976

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);