issue_comments

Thanks @headtr1ck ! :)

Yeah, I had some strange issues there. One was that the branch wasn't up to date and another one that I can't replicate anymore... Sorry for the noise,

Agreed on the labels, I haven't figured how to avoid that overlap yet. y should point to the top as it does in 2D plots, it makes it easy to orient yourself as you add dimensions: python ds = xr.tutorial.scatter_example_dataset(seed=42) fg = ds.plot.scatter(x="A", y="B", hue="y", row="x", col="w") fg = ds.plot.scatter(x="A", y="B", z="z", hue="y", row="x", col="w")

Not how it's done in plots2d (yet) though.

I use windows as well. :) I just had my plot in an interactive window that was maximized.

I can get it too look as bad as yours as well:

edit

Anyway, you should use kwargs for x and y as well :)

Hah, unfortunately my random test scripts I copy/pasted from can't keep up with branches. :D

This crashes now. Maybe you'll find the bug faster than me. ```python import xarray as xr

ds = xr.tutorial.scatter_example_dataset(seed=42) fg = ds.plot.scatter("A", "B", z="z", hue="y", row="x", col="w")

Traceback (most recent call last):

File "C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\spyder_kernels\py3compat.py", line 356, in compat_exec exec(code, globals, locals)

File "g:\program\dropbox\python\xarray_line_plot.py", line 122, in <module> fg = ds.plot.scatter("A", "B", z="z", hue="y", row="x", col="w")

File "C:\Users\J.W\Documents\GitHub\xarray\xarray\plot\accessor.py", line 975, in scatter return dataset_plot.scatter(self._ds, args, *kwargs)

File "C:\Users\J.W\Documents\GitHub\xarray\xarray\plot\dataset_plot.py", line 234, in newplotfunc return _easy_facetgrid(kind="dataset", allargs, kwargs)

File "C:\Users\J.W\Documents\GitHub\xarray\xarray\plot\facetgrid.py", line 770, in _easy_facetgrid return g.map_dataset(plotfunc, x, y, **kwargs)

File "C:\Users\J.W\Documents\GitHub\xarray\xarray\plot\facetgrid.py", line 370, in map_dataset maybe_mappable = func(

File "C:\Users\J.W\Documents\GitHub\xarray\xarray\plot\dataset_plot.py", line 262, in newplotfunc primitive = plotfunc(

File "C:\Users\J.W\Documents\GitHub\xarray\xarray\plot\dataset_plot.py", line 541, in scatter primitive = ax.scatter(

File "C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\matplotlib__init__.py", line 1423, in inner return func(ax, map(sanitize_sequence, args), *kwargs)

File "C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\matplotlib\axes_axes.py", line 4626, in scatter collection._internal_update(kwargs)

File "C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\matplotlib\artist.py", line 1186, in _internal_update return self._update_props(

File "C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\matplotlib\artist.py", line 1160, in _update_props raise AttributeError(

AttributeError: PathCollection.set() got an unexpected keyword argument 'z' ```

I've merged the PR. :) Have fun with the conflicts!

I've merged the easy ones now. I'm not as confident on #6778 and could use another review on it.

Maybe there's something to learn from how pandas does it: https://github.com/pandas-dev/pandas/tree/main/pandas/plotting ?

I'm a little skeptical if all the arguments in scatter are necessary and maybe they can be hidden in kwargs? Should make the overloads a little shorter.

I've been working on moving all plots to the DataArray side starting with scatter in #6778. It should also remove the list[PathCollection] overloads.