issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 1376479521 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 2

issue 1

  • Add Ellipsis typehint to reductions · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1250318962 https://github.com/pydata/xarray/pull/7048#issuecomment-1250318962 https://api.github.com/repos/pydata/xarray/issues/7048 IC_kwDOAMm_X85Khlpy Illviljan 14371165 2022-09-18T14:20:51Z 2022-09-18T14:20:51Z MEMBER

Just running that script file several times without restarting the console. It might be a Spyder bug though since I can't reproduce it in a stand alone ipython console.

This for example works (the first time): ``` python import numpy as np import pandas as pd import xarray as xr

da = xr.DataArray( np.array([1, 2, 3, 1, 2, np.nan]), dims="time", coords=dict( time=("time", pd.date_range("01-01-2001", freq="M", periods=6)), labels=("time", np.array(["a", "b", "c", "c", "b", "a"])), ), ) da.groupby("labels").count()

da = xr.DataArray( np.array([1, 2, 3, 1, 2, np.nan]), dims="time", coords=dict( time=("time", pd.date_range("01-01-2001", freq="M", periods=6)), labels=("time", np.array(["a", "b", "c", "c", "b", "a"])), ), ) da.groupby("labels").count() ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add Ellipsis typehint to reductions 1376479521
1250208324 https://github.com/pydata/xarray/pull/7048#issuecomment-1250208324 https://api.github.com/repos/pydata/xarray/issues/7048 IC_kwDOAMm_X85KhKpE Illviljan 14371165 2022-09-18T07:13:43Z 2022-09-18T07:15:39Z MEMBER

```diff @@ -4400,7 +4400,7 @@ def count(

     >>> da.groupby("labels").count()
     <xarray.DataArray (labels: 3)>
  • array([1, 2, 2], dtype=int64)
  • array([1, 2, 2]) Coordinates: * labels (labels) object 'a' 'b' 'c' """ ```

Is it just me that this example crashes the second time I run it? ``` python import numpy as np import pandas as pd import xarray as xr

da = xr.DataArray( np.array([1, 2, 3, 1, 2, np.nan]), dims="time", coords=dict( time=("time", pd.date_range("01-01-2001", freq="M", periods=6)), labels=("time", np.array(["a", "b", "c", "c", "b", "a"])), ), ) da.groupby("labels").count() ```

```python Traceback (most recent call last): File "C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\spyder_kernels\py3compat.py", line 356, in compat_exec exec(code, globals, locals) File "g:\program\dropbox\python\xarray_groupby_windows_diff.py", line 34, in <module> da.groupby("labels").count() File "c:\users\j.w\documents\github\xarray\xarray\core\_reductions.py", line 4384, in count return self._flox_reduce( File "c:\users\j.w\documents\github\xarray\xarray\core\groupby.py", line 738, in _flox_reduce result = xarray_reduce( File "C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\flox\xarray.py", line 240, in xarray_reduce ds, *by = xr.broadcast(ds, *by, exclude=exclude_dims) File "c:\users\j.w\documents\github\xarray\xarray\core\alignment.py", line 1046, in broadcast args = align(*args, join="outer", copy=False, exclude=exclude) File "c:\users\j.w\documents\github\xarray\xarray\core\alignment.py", line 765, in align aligner.align() File "c:\users\j.w\documents\github\xarray\xarray\core\alignment.py", line 549, in align self.find_matching_indexes() File "c:\users\j.w\documents\github\xarray\xarray\core\alignment.py", line 256, in find_matching_indexes obj_indexes, obj_index_vars = self._normalize_indexes(obj.xindexes) File "c:\users\j.w\documents\github\xarray\xarray\core\alignment.py", line 205, in _normalize_indexes pd_idx = safe_cast_to_index(data) File "c:\users\j.w\documents\github\xarray\xarray\core\utils.py", line 140, in safe_cast_to_index index = pd.Index(np.asarray(array), **kwargs) File "C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\pandas\core\indexes\base.py", line 483, in __new__ data = sanitize_array(data, None, dtype=dtype, copy=copy) File "C:\Users\J.W\anaconda3\envs\xarray-tests\lib\site-packages\pandas\core\construction.py", line 524, in sanitize_array raise ValueError("index must be specified when data is not list-like") ValueError: index must be specified when data is not list-like ``` 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add Ellipsis typehint to reductions 1376479521
1250129625 https://github.com/pydata/xarray/pull/7048#issuecomment-1250129625 https://api.github.com/repos/pydata/xarray/issues/7048 IC_kwDOAMm_X85Kg3bZ max-sixty 5635139 2022-09-17T19:38:08Z 2022-09-17T19:38:08Z MEMBER

Here's the diff from pytest-accept (it is weird that it's slightly different on windows...)

```diff commit 83615a94a6b7c0ae0cf0e0240d7705d9ce6c21e5 Author: Maximilian Roos m@maxroos.com Date: Sat Sep 17 12:36:45 2022 -0700

pytest-accept

diff --git a/xarray/core/_reductions.py b/xarray/core/_reductions.py index a7cf7ec2..d0c2a9d7 100644 --- a/xarray/core/_reductions.py +++ b/xarray/core/_reductions.py @@ -97,7 +97,7 @@ def count( <xarray.Dataset> Dimensions: () Data variables: - da int32 5 + da int64 5 """ return self.reduce( duck_array_ops.count, @@ -4400,7 +4400,7 @@ def count(

     >>> da.groupby("labels").count()
     <xarray.DataArray (labels: 3)>
  • array([1, 2, 2], dtype=int64)
  • array([1, 2, 2]) Coordinates: * labels (labels) object 'a' 'b' 'c' """ @@ -5485,7 +5485,7 @@ def count(
     >>> da.resample(time="3M").count()
 <xarray.DataArray (time: 3)>
    • array([1, 3, 1], dtype=int64)
    • array([1, 3, 1]) Coordinates:
      • time (time) datetime64[ns] 2001-01-31 2001-04-30 2001-07-31 """ ```
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Add Ellipsis typehint to reductions 1376479521
1249855286 https://github.com/pydata/xarray/pull/7048#issuecomment-1249855286 https://api.github.com/repos/pydata/xarray/issues/7048 IC_kwDOAMm_X85Kf0c2 max-sixty 5635139 2022-09-16T21:46:16Z 2022-09-16T21:46:16Z MEMBER

Excellent @headtr1ck !

Do we need to run pytest --accept to get the docstrings? It looks like we lost lots...

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 1
}
   Add Ellipsis typehint to reductions 1376479521

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);