issue_comments
17 rows where author_association = "MEMBER" and issue = 1363829843 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: reactions, created_at (date), updated_at (date)
issue 1
- list available backends and basic descriptors · 17 ✖
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | performed_via_github_app | issue |
---|---|---|---|---|---|---|---|---|---|---|---|
1281108096 | https://github.com/pydata/xarray/pull/7000#issuecomment-1281108096 | https://api.github.com/repos/pydata/xarray/issues/7000 | IC_kwDOAMm_X85MXCiA | dcherian 2448579 | 2022-10-17T16:04:49Z | 2022-10-17T16:04:49Z | MEMBER | @headtr1ck the typing changes didn't work. Can you send in a separate PR for that please? |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
list available backends and basic descriptors 1363829843 | |
1279048760 | https://github.com/pydata/xarray/pull/7000#issuecomment-1279048760 | https://api.github.com/repos/pydata/xarray/issues/7000 | IC_kwDOAMm_X85MPLw4 | JessicaS11 11756442 | 2022-10-14T13:59:06Z | 2022-10-14T13:59:06Z | MEMBER |
@headtr1ck GitHub is unhelpfully not showing me any comments. Can you share a screen shot or something so I can address them? Thanks! |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
list available backends and basic descriptors 1363829843 | |
1266031250 | https://github.com/pydata/xarray/pull/7000#issuecomment-1266031250 | https://api.github.com/repos/pydata/xarray/issues/7000 | IC_kwDOAMm_X85LdhqS | dcherian 2448579 | 2022-10-03T20:50:18Z | 2022-10-03T20:50:18Z | MEMBER |
Did you discuss adding |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
list available backends and basic descriptors 1363829843 | |
1261359689 | https://github.com/pydata/xarray/pull/7000#issuecomment-1261359689 | https://api.github.com/repos/pydata/xarray/issues/7000 | IC_kwDOAMm_X85LLtJJ | TomNicholas 35968931 | 2022-09-28T19:16:04Z | 2022-09-29T21:38:09Z | MEMBER |
Looks like they are - every subclass of EDIT: (Actually we should wait to put tests in too really) |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
list available backends and basic descriptors 1363829843 | |
1247111973 | https://github.com/pydata/xarray/pull/7000#issuecomment-1247111973 | https://api.github.com/repos/pydata/xarray/issues/7000 | IC_kwDOAMm_X85KVWsl | TomNicholas 35968931 | 2022-09-14T17:52:12Z | 2022-09-14T17:52:12Z | MEMBER | We discussed this with Jessica in the xarray community meeting today and I think the conclusion was to return a dict of backend objects with nice reprs to begin with, and if there is appetite then prettify it later, likely with a custom mutable mapping with special repr. |
{ "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
list available backends and basic descriptors 1363829843 | |
1244529390 | https://github.com/pydata/xarray/pull/7000#issuecomment-1244529390 | https://api.github.com/repos/pydata/xarray/issues/7000 | IC_kwDOAMm_X85KLgLu | TomNicholas 35968931 | 2022-09-12T21:40:06Z | 2022-09-12T21:43:34Z | MEMBER |
I like this idea more than using a EDIT: This would also be a good thing to split out into an (optional) future PR though, and merge returning a dict of objects with nice individual reprs for now. |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
list available backends and basic descriptors 1363829843 | |
1244499083 | https://github.com/pydata/xarray/pull/7000#issuecomment-1244499083 | https://api.github.com/repos/pydata/xarray/issues/7000 | IC_kwDOAMm_X85KLYyL | Illviljan 14371165 | 2022-09-12T21:22:31Z | 2022-09-12T21:22:31Z | MEMBER | My 2 cents is that If the dict repr from |
{ "total_count": 2, "+1": 2, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
list available backends and basic descriptors 1363829843 | |
1244154384 | https://github.com/pydata/xarray/pull/7000#issuecomment-1244154384 | https://api.github.com/repos/pydata/xarray/issues/7000 | IC_kwDOAMm_X85KKEoQ | JessicaS11 11756442 | 2022-09-12T18:49:37Z | 2022-09-12T18:49:37Z | MEMBER |
Turns out it was already available so I added it to the Advance API docs as well as https://docs.xarray.dev/en/stable/internals/how-to-add-new-backend.html. @dcherian I'll bookmark adding it to https://tutorial.xarray.dev/advanced/backends/backends.html. @Illviljan, in case you didn't see this prior discussion:
Do you have any suggestions? Note: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
list available backends and basic descriptors 1363829843 | |
1244125614 | https://github.com/pydata/xarray/pull/7000#issuecomment-1244125614 | https://api.github.com/repos/pydata/xarray/issues/7000 | IC_kwDOAMm_X85KJ9mu | Illviljan 14371165 | 2022-09-12T18:21:05Z | 2022-09-12T18:21:05Z | MEMBER | ```
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
list available backends and basic descriptors 1363829843 | |
1243941285 | https://github.com/pydata/xarray/pull/7000#issuecomment-1243941285 | https://api.github.com/repos/pydata/xarray/issues/7000 | IC_kwDOAMm_X85KJQml | dcherian 2448579 | 2022-09-12T15:51:34Z | 2022-09-12T15:51:34Z | MEMBER | Thanks Jessica!
We could also just document using |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
list available backends and basic descriptors 1363829843 | |
1243873325 | https://github.com/pydata/xarray/pull/7000#issuecomment-1243873325 | https://api.github.com/repos/pydata/xarray/issues/7000 | IC_kwDOAMm_X85KJAAt | TomNicholas 35968931 | 2022-09-12T15:01:07Z | 2022-09-12T15:01:07Z | MEMBER |
I think exposing a Expanding on that, we could put |
{ "total_count": 1, "+1": 1, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
list available backends and basic descriptors 1363829843 | |
1243848597 | https://github.com/pydata/xarray/pull/7000#issuecomment-1243848597 | https://api.github.com/repos/pydata/xarray/issues/7000 | IC_kwDOAMm_X85KI5-V | JessicaS11 11756442 | 2022-09-12T14:43:04Z | 2022-09-12T14:43:04Z | MEMBER |
Currently there is this method: ```
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
list available backends and basic descriptors 1363829843 | |
1243754342 | https://github.com/pydata/xarray/pull/7000#issuecomment-1243754342 | https://api.github.com/repos/pydata/xarray/issues/7000 | IC_kwDOAMm_X85KIi9m | TomNicholas 35968931 | 2022-09-12T13:35:37Z | 2022-09-12T13:35:37Z | MEMBER |
This is helpful already, thank you.
I guess not, but we also probably don't want to pollute xarray's public namespace with multiple functions that do basically the same thing. Though maybe as it's all behind the backends namespace that doesn't matter so much? Then we might have |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
list available backends and basic descriptors 1363829843 | |
1241174924 | https://github.com/pydata/xarray/pull/7000#issuecomment-1241174924 | https://api.github.com/repos/pydata/xarray/issues/7000 | IC_kwDOAMm_X85J-tOM | JessicaS11 11756442 | 2022-09-08T20:03:11Z | 2022-09-08T20:03:11Z | MEMBER |
Agreed. I added a
... I haven't dreamed up an answer to this question yet. We could set it up so that |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
list available backends and basic descriptors 1363829843 | |
1240920968 | https://github.com/pydata/xarray/pull/7000#issuecomment-1240920968 | https://api.github.com/repos/pydata/xarray/issues/7000 | IC_kwDOAMm_X85J9vOI | TomNicholas 35968931 | 2022-09-08T16:05:01Z | 2022-09-08T16:09:05Z | MEMBER |
So what would the return type need to be to get a nice table representation, but also allow you to select out individual backend objects? A pandas object containing the backend objects? Some kind of
Correct me if I'm wrong, but if a subclassed |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
list available backends and basic descriptors 1363829843 | |
1240883537 | https://github.com/pydata/xarray/pull/7000#issuecomment-1240883537 | https://api.github.com/repos/pydata/xarray/issues/7000 | IC_kwDOAMm_X85J9mFR | TomNicholas 35968931 | 2022-09-08T15:34:11Z | 2022-09-08T15:34:11Z | MEMBER | Hey @JessicaS11! Nice to see you here. This is a going to be a great first-time contribution!
One approach might be to add a nice ```python class BackendEntryPoint: ...
``` What might be clearer is if this backend class knew it's own name, but I'm not sure it can, hmmm |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
list available backends and basic descriptors 1363829843 | |
1239824690 | https://github.com/pydata/xarray/pull/7000#issuecomment-1239824690 | https://api.github.com/repos/pydata/xarray/issues/7000 | IC_kwDOAMm_X85J5jky | JessicaS11 11756442 | 2022-09-07T20:12:51Z | 2022-09-07T20:12:51Z | MEMBER |
Sounds good - I'll make that happen! |
{ "total_count": 1, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 1, "rocket": 0, "eyes": 0 } |
list available backends and basic descriptors 1363829843 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [performed_via_github_app] TEXT, [issue] INTEGER REFERENCES [issues]([id]) ); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
user 4