issue_comments

Table actions

where author_association = "MEMBER", issue = 1353467346 and user = 5635139 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • max-sixty · 3 ✖

issue 1

  • Fixed type errors in `mypy` GitHub Action · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1278199058 https://github.com/pydata/xarray/pull/6963#issuecomment-1278199058 https://api.github.com/repos/pydata/xarray/issues/6963 IC_kwDOAMm_X85ML8US max-sixty 5635139 2022-10-13T21:29:33Z 2022-10-13T21:29:33Z MEMBER

I can't repro the failure on the current PR v0.17.0-804-g7018b950. I'm using Python 3.9 with the latest dask.

/home/runner/micromamba/envs/xarray-tests/lib/python3.10/site-packages/dask/utils.py:366: error: Parenthesized context managers are only supported in Python 3.9 and greater [syntax] Found 1 error in 1 file (errors prevented further checking)

I'm not sure why it's raising an error for an imported module where --follow-imports=silent. Isn't that supposed to suppress errors in imports?

And weirdly, I get errors running mypy in dask latest main, but not this error!

❯ mypy --python-version 3.8 . dask/system.py:8: error: Unused "type: ignore" comment dask/widgets/__init__.py:20: error: All conditional function variants must have identical signatures [misc] dask/widgets/__init__.py:23: error: All conditional function variants must have identical signatures [misc] dask/layers.py:1322: error: Unused "type: ignore" comment dask/layers.py:1323: error: Unused "type: ignore" comment dask/array/core.py:5814: error: Argument 1 to "ndindex" has incompatible type "Tuple[int, ...]"; expected "SupportsIndex" [arg-type] dask/array/fft.py:196: error: Unused "type: ignore" comment dask/dataframe/core.py:438: error: Unused "type: ignore" comment dask/dataframe/core.py:4186: error: Unused "type: ignore" comment dask/dataframe/core.py:4197: error: Unused "type: ignore" comment dask/dataframe/core.py:4209: error: Unused "type: ignore" comment dask/dataframe/core.py:4408: error: Unused "type: ignore" comment dask/dataframe/core.py:4420: error: Unused "type: ignore" comment dask/dataframe/core.py:4425: error: Unused "type: ignore" comment dask/dataframe/groupby.py:1204: error: Unused "type: ignore" comment dask/dataframe/io/csv.py:9: error: Unused "type: ignore" comment dask/bytes/tests/test_s3.py:380: error: Unused "type: ignore" comment dask/bytes/tests/test_local.py:191: error: Unused "type: ignore" comment dask/bag/tests/test_text.py:33: error: Unused "type: ignore" comment dask/dataframe/tests/test_shuffle.py:1408: error: Unused "type: ignore" comment dask/dataframe/tests/test_shuffle.py:1409: error: Unused "type: ignore" comment dask/dataframe/tests/test_shuffle.py:1412: error: Unused "type: ignore" comment dask/diagnostics/tests/test_profiler.py:21: error: Unused "type: ignore" comment dask/tests/test_graph_manipulation.py:106: error: "tuple" is not subscriptable, use "typing.Tuple" instead [misc] Found 24 errors in 14 files (checked 243 source files)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed type errors in `mypy` GitHub Action 1353467346
1278122952 https://github.com/pydata/xarray/pull/6963#issuecomment-1278122952 https://api.github.com/repos/pydata/xarray/issues/6963 IC_kwDOAMm_X85MLpvI max-sixty 5635139 2022-10-13T20:07:43Z 2022-10-13T20:07:43Z MEMBER

Hmmm, these errors should be fixed in the latest version of this PR.

Sorry, my test was on main. I can rerun on this PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed type errors in `mypy` GitHub Action 1353467346
1278119369 https://github.com/pydata/xarray/pull/6963#issuecomment-1278119369 https://api.github.com/repos/pydata/xarray/issues/6963 IC_kwDOAMm_X85MLo3J max-sixty 5635139 2022-10-13T20:03:50Z 2022-10-13T20:03:50Z MEMBER

I get some errors:

``` ❯ git describe v0.17.0-798-g3599f873

❯ mypy --python-version 3.8 xarray/core/types.py:72: error: "tuple" is not subscriptable [misc] xarray/core/types.py:74: error: "tuple" is not subscriptable [misc] xarray/core/types.py:76: error: "tuple" is not subscriptable [misc] xarray/core/types.py:78: error: "list" is not subscriptable [misc] xarray/core/_reductions.py:18: error: Cannot find implementation or library stub for module named "flox" [import] xarray/core/_reductions.py:18: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports xarray/core/merge.py:43: error: "tuple" is not subscriptable [misc] xarray/core/merge.py:44: error: "tuple" is not subscriptable [misc] xarray/core/merge.py:45: error: "tuple" is not subscriptable [misc] xarray/core/groupby.py:661: error: Cannot find implementation or library stub for module named "flox.xarray" [import] xarray/backends/api.py:65: error: "dict" is not subscriptable [misc] Found 10 errors in 5 files (checked 139 source files) ```

(not sure why git describe is showing that tag but the commit hash should repro)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fixed type errors in `mypy` GitHub Action 1353467346

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);