issue_comments

Table actions

2 rows where author_association = "MEMBER" and issue = 1333514579 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • Flox based groupby operations don't support `dtype` in mean method · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1209641946 https://github.com/pydata/xarray/issues/6902#issuecomment-1209641946 https://api.github.com/repos/pydata/xarray/issues/6902 IC_kwDOAMm_X85IGava Illviljan 14371165 2022-08-09T17:05:35Z 2022-08-09T17:07:08Z MEMBER

It's not crashing for me, but the dtype is not the same when switching flox on/off:

```python ds = xr.tutorial.load_dataset("air_temperature") assert ds.air.dtype == np.float32

for use_flox in (False, True): with xr.set_options(use_flox=use_flox): ds_mean = ds.groupby("time.month").mean(dtype="float64").compute() actual = ds_mean.air.dtype expected = np.float64 print(f"{use_flox=}, {actual=}, {expected=}") assert actual == expected

use_flox=False, actual=dtype('float64'), expected=<class 'numpy.float64'>

use_flox=True, actual=dtype('float32'), expected=<class 'numpy.float64'>

```

xr.show_versions()

INSTALLED VERSIONS ------------------ commit: None python: 3.9.13 | packaged by conda-forge | (main, May 27 2022, 16:50:36) [MSC v.1929 64 bit (AMD64)] python-bits: 64 OS: Windows OS-release: 10 machine: AMD64 processor: Intel64 Family 6 Model 58 Stepping 9, GenuineIntel byteorder: little LC_ALL: None LANG: en libhdf5: 1.12.1 libnetcdf: 4.8.1 xarray: 0.16.3.dev99+gc19467fb pandas: 1.4.2 numpy: 1.22.4 scipy: 1.8.1 netCDF4: 1.5.8 pydap: installed h5netcdf: 1.0.0 h5py: 3.6.0 Nio: None zarr: 2.11.3 cftime: 1.6.0 nc_time_axis: 1.4.1 PseudoNetCDF: 3.2.2 rasterio: 1.2.10 cfgrib: None iris: 3.2.1 bottleneck: 1.3.4 dask: 2022.6.0 distributed: 2022.6.0 matplotlib: 3.5.2 cartopy: 0.20.2 seaborn: 0.11.2 numbagg: 0.2.1 fsspec: 2022.7.1 cupy: None pint: 0.19.2 sparse: 0.13.0 flox: 0.5.5 numpy_groupies: 0.9.17 setuptools: 62.5.0 pip: 22.1.2 conda: None pytest: 7.1.2 IPython: 7.33.0 sphinx: 5.1.1 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Flox based groupby operations don't support `dtype` in mean method 1333514579
1209615886 https://github.com/pydata/xarray/issues/6902#issuecomment-1209615886 https://api.github.com/repos/pydata/xarray/issues/6902 IC_kwDOAMm_X85IGUYO dcherian 2448579 2022-08-09T16:38:36Z 2022-08-09T16:38:36Z MEMBER

Yeah I think we need to fix this in flox.

Can you come up with a simple test case that checks that the accumulation is done properly?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Flox based groupby operations don't support `dtype` in mean method 1333514579

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);