issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 1323521079 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • keewis · 2 ✖

issue 1

  • Testing DataArray equality using built-in '==' operator leads to mutilated DataArray.attrs dictionary · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1200925682 https://github.com/pydata/xarray/issues/6852#issuecomment-1200925682 https://api.github.com/repos/pydata/xarray/issues/6852 IC_kwDOAMm_X85HlKvy keewis 14808389 2022-08-01T09:06:16Z 2022-08-01T09:11:52Z MEMBER

bisecting tells me this is a regression introduced by #6389. Looking at the code, this happens because copying the variables with variables.copy() makes a shallow copy of the dictionary (and not its values), which means that we're actually mutating the Dataset variables. If I change that line to ```python

make a shallow copy of each variable

new_variables = {name: var.copy() for name, var in variables.items()} ``` we stop mutating the dataset.

cc @benbovy

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Testing DataArray equality using built-in '==' operator leads to mutilated DataArray.attrs dictionary 1323521079
1200463448 https://github.com/pydata/xarray/issues/6852#issuecomment-1200463448 https://api.github.com/repos/pydata/xarray/issues/6852 IC_kwDOAMm_X85HjZ5Y keewis 14808389 2022-07-31T17:07:55Z 2022-07-31T17:45:05Z MEMBER

~can you try if setting keep_attrs=True helps?~

That's wrong, I can reproduce the side-effects. Not sure where that's coming from, though. And interestingly, only the first operand is mutated, da_withoutunits == da_withunits does not drop the units on da_withunits.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Testing DataArray equality using built-in '==' operator leads to mutilated DataArray.attrs dictionary 1323521079

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);