issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 1318800553 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Require a pull request before merging to main · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1198375377 https://github.com/pydata/xarray/issues/6833#issuecomment-1198375377 https://api.github.com/repos/pydata/xarray/issues/6833 IC_kwDOAMm_X85HbcHR shoyer 1217238 2022-07-28T16:29:30Z 2022-07-28T16:29:30Z MEMBER

I just toggled the "Require a pull request before merging" option

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Require a pull request before merging to main 1318800553
1197129426 https://github.com/pydata/xarray/issues/6833#issuecomment-1197129426 https://api.github.com/repos/pydata/xarray/issues/6833 IC_kwDOAMm_X85HWr7S max-sixty 5635139 2022-07-27T18:15:00Z 2022-07-27T18:15:00Z MEMBER

If this is helpful to anyone, here are some configs I use to: a) avoid opening a browser b) avoid pushing to main

This will push the current branch, and tell GH to merge as soon as test pass. I never feel the need to push to main now; even something like the release cleanup can be done through an PR.

pub-merge-gh = !git publish && gh pr create --fill && gh pr merge --auto --squash --delete-branch publish = "!git push --set-upstream origin $(git branch --show-current)"

(the latter can be replaced with push with the latest version of git & [push]; autoSetupRemote = true configs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Require a pull request before merging to main 1318800553
1196453161 https://github.com/pydata/xarray/issues/6833#issuecomment-1196453161 https://api.github.com/repos/pydata/xarray/issues/6833 IC_kwDOAMm_X85HUG0p keewis 14808389 2022-07-27T08:58:30Z 2022-07-27T09:06:29Z MEMBER

there are still cases where it would be good to allow pushing to main, the most notable being the release bump / cleanup (but maybe we can temporarily allow pushes for that?).

There's a few settings in git you can use to make this harder, though: - set the default push remote for main to your own fork: that way, you can still explicitly push (git push origin main), but the usual git push will push to your fork (instead of editing .git/config directly you can also use magit's P C menu, if you use emacs and magit): ini [remote] pushDefault = myfork # to generally avoid pushing to the main repository [branch "main"] pushRemote = myfork # specifically for main - create a pre-push hook that will refuse pushing to main (you can still disable it with git push --no-verify)

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Require a pull request before merging to main 1318800553
1196285473 https://github.com/pydata/xarray/issues/6833#issuecomment-1196285473 https://api.github.com/repos/pydata/xarray/issues/6833 IC_kwDOAMm_X85HTd4h TomNicholas 35968931 2022-07-27T05:36:38Z 2022-07-27T05:36:38Z MEMBER

I've also accidentally done this before and would also prefer a guard against my own trigger finger :sweat_smile: 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Require a pull request before merging to main 1318800553

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);