issue_comments

Table actions

4 rows where author_association = "MEMBER" and issue = 1308371056 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

issue 1

  • New alignment option: "exact" without broadcasting OR Turn off automatic broadcasting · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1188966372 https://github.com/pydata/xarray/issues/6806#issuecomment-1188966372 https://api.github.com/repos/pydata/xarray/issues/6806 IC_kwDOAMm_X85G3i_k benbovy 4160723 2022-07-19T12:02:00Z 2022-07-19T12:02:00Z MEMBER

Ah ok I see, thanks! Yes I agree this may be useful.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   New alignment option: "exact" without broadcasting OR Turn off automatic broadcasting 1308371056
1188339194 https://github.com/pydata/xarray/issues/6806#issuecomment-1188339194 https://api.github.com/repos/pydata/xarray/issues/6806 IC_kwDOAMm_X85G1J36 dcherian 2448579 2022-07-18T21:35:44Z 2022-07-18T21:35:44Z MEMBER

Basically I want the following to raise an error because I've picked the wrong variable with dimension x1 instead of dimension x by mistake

python xr.DataArray([1], dims="x") / xr.DataArray([1], dims="x1")

I think we could do it with a "staggered grid index", but it seems useful in general 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   New alignment option: "exact" without broadcasting OR Turn off automatic broadcasting 1308371056
1188305230 https://github.com/pydata/xarray/issues/6806#issuecomment-1188305230 https://api.github.com/repos/pydata/xarray/issues/6806 IC_kwDOAMm_X85G1BlO TomNicholas 35968931 2022-07-18T21:00:29Z 2022-07-18T21:00:29Z MEMBER

I'm curious to see if in that specific case using a custom index for staggered grid coordinates wouldn't work as an alternative solution. The alignment rules are pretty strict (same index type + same sequence of coordinate names & dims). Not 100% sure if that applies in the xgcm case, but in theory it would raise an error regardless of the join method if you try to align objects that have broadcastable coordinates with incompatible indexes.

This is on my to-do list to think about really hard :sweat_smile:

I think one problem would be that sometimes a different grid position implies a different length coordinate array, e.g. "outer" vs "center" is larger by one element.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   New alignment option: "exact" without broadcasting OR Turn off automatic broadcasting 1308371056
1188281362 https://github.com/pydata/xarray/issues/6806#issuecomment-1188281362 https://api.github.com/repos/pydata/xarray/issues/6806 IC_kwDOAMm_X85G07wS benbovy 4160723 2022-07-18T20:37:03Z 2022-07-18T20:37:03Z MEMBER

This turns up in staggered grid calculations with xgcm where it is easy to mistakenly construct very high-dimensional arrays because of automatic broadcasting.

Do you have an example that illustrates this issue?

I'm curious to see if in that specific case using a custom index for staggered grid coordinates wouldn't work as an alternative solution. The alignment rules are pretty strict (same index type + same sequence of coordinate names & dims). Not 100% sure if that applies in the xgcm case, but in theory it would raise an error regardless of the join method if you try to align objects that have broadcastable coordinates with incompatible indexes.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   New alignment option: "exact" without broadcasting OR Turn off automatic broadcasting 1308371056

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);