issue_comments

Table actions

5 rows where author_association = "MEMBER" and issue = 130753818 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • merge and align DataArrays/Datasets on different domains · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
274641536 https://github.com/pydata/xarray/issues/742#issuecomment-274641536 https://api.github.com/repos/pydata/xarray/issues/742 MDEyOklzc3VlQ29tbWVudDI3NDY0MTUzNg== shoyer 1217238 2017-01-23T22:42:18Z 2017-01-23T22:42:18Z MEMBER

Fixed by #996

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge and align DataArrays/Datasets on different domains 130753818
242239306 https://github.com/pydata/xarray/issues/742#issuecomment-242239306 https://api.github.com/repos/pydata/xarray/issues/742 MDEyOklzc3VlQ29tbWVudDI0MjIzOTMwNg== shoyer 1217238 2016-08-24T23:27:41Z 2016-08-24T23:27:41Z MEMBER

@jcmgray Yes, that looks about right to me. The place to add this in would be the unique_variable function: https://github.com/pydata/xarray/blob/master/xarray/core/merge.py#L39

I would use 'notnull_equals' rather than 'nonnull_equals' just because that's the pandas term.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge and align DataArrays/Datasets on different domains 130753818
227053256 https://github.com/pydata/xarray/issues/742#issuecomment-227053256 https://api.github.com/repos/pydata/xarray/issues/742 MDEyOklzc3VlQ29tbWVudDIyNzA1MzI1Ng== shoyer 1217238 2016-06-20T05:29:59Z 2016-06-20T05:29:59Z MEMBER

@JamesPHoughton @jcmgray For empty array creation, take a look at https://github.com/pydata/xarray/issues/277 and https://github.com/pydata/xarray/issues/878 -- this functionality would certainly be welcome.

To go with this (and this might be separate issue), a set_value method would be helpful --- just so that one does not have to remember which particular combination of...

@jcmgray Beware -- none of these are actually supported! See the big warning here in the docs. If you think a set_value method would be a better reminder than such warnings in the docs I would be totally open to it. But let's open another issue to discuss it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge and align DataArrays/Datasets on different domains 130753818
226249845 https://github.com/pydata/xarray/issues/742#issuecomment-226249845 https://api.github.com/repos/pydata/xarray/issues/742 MDEyOklzc3VlQ29tbWVudDIyNjI0OTg0NQ== shoyer 1217238 2016-06-15T16:54:45Z 2016-06-15T16:54:45Z MEMBER

I think this could make it into merge, which I am in the process of refactoring in https://github.com/pydata/xarray/pull/857.

The key difference from @jcmgray's implementation that I would want is a check to make sure that the data is all on different domains when using fillna. merge should not run the risk of removing non-NaN data.

@JamesPHoughton I agree with @jcmgray that the dtype=object is what you should expect here. It's hard to create fixed length strings in xarray/pandas because that precludes the possibility of missing values, so we tend to convert strings to object dtype when merged/concatenated.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge and align DataArrays/Datasets on different domains 130753818
178997890 https://github.com/pydata/xarray/issues/742#issuecomment-178997890 https://api.github.com/repos/pydata/xarray/issues/742 MDEyOklzc3VlQ29tbWVudDE3ODk5Nzg5MA== shoyer 1217238 2016-02-03T04:23:31Z 2016-06-15T16:50:43Z MEMBER

This is actually closer to the functionality of concat than merge. Hypothetically, something like the following would do what you want:

```

note: this is not valid syntax currently! the dims arguments

does not yet exist.

this would hypothetically only align along the 'y' dimension, not 'x'

aligned = xr.align(*das, join='outer', dims='y') combined = xr.concat(aligned, dim='x') ```

In cases where each array does not already have the dimension you want to concat along, this already works fine, because you can simply omit dims in align.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   merge and align DataArrays/Datasets on different domains 130753818

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);