issue_comments

Table actions

4 rows where author_association = "MEMBER", issue = 1285767883 and user = 10194086 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • mathause · 4 ✖

issue 1

  • move da and ds fixtures to conftest.py · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1180346845 https://github.com/pydata/xarray/pull/6730#issuecomment-1180346845 https://api.github.com/repos/pydata/xarray/issues/6730 IC_kwDOAMm_X85GWqnd mathause 10194086 2022-07-11T12:25:57Z 2022-07-11T12:25:57Z MEMBER

I renamed the fixtures back to da & ds to make the PR smaller & will merge once the checks are green... 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   move da and ds fixtures to conftest.py 1285767883
1172313707 https://github.com/pydata/xarray/pull/6730#issuecomment-1172313707 https://api.github.com/repos/pydata/xarray/issues/6730 IC_kwDOAMm_X85F4BZr mathause 10194086 2022-07-01T12:51:44Z 2022-07-01T12:51:44Z MEMBER

@max-sixty: so keep da or switch to dataarray for the fixture?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   move da and ds fixtures to conftest.py 1285767883
1172306026 https://github.com/pydata/xarray/pull/6730#issuecomment-1172306026 https://api.github.com/repos/pydata/xarray/issues/6730 IC_kwDOAMm_X85F3_hq mathause 10194086 2022-07-01T12:42:40Z 2022-07-01T12:42:40Z MEMBER

Any chance that these might shadow the dataarray and dataset modules? Although I think it is not very common to import these modules directly in the tests.

Good point, haven't thought of this. But I think these are not imported. Staying with da and ds would also reduce the diff...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   move da and ds fixtures to conftest.py 1285767883
1167836680 https://github.com/pydata/xarray/pull/6730#issuecomment-1167836680 https://api.github.com/repos/pydata/xarray/issues/6730 IC_kwDOAMm_X85Fm8YI mathause 10194086 2022-06-27T20:14:26Z 2022-06-27T20:14:26Z MEMBER

I found the names da and ds a bit ambiguous. I am happy to adapt to something more common of course - your suggestion would be to name them dataarray and dataset?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   move da and ds fixtures to conftest.py 1285767883

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);