issue_comments

Table actions

2 rows where author_association = "MEMBER", issue = 1275752720 and user = 4160723 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • benbovy · 2 ✖

issue 1

  • Future of `DataArray.rename` · 2 ✖

author_association 1

  • MEMBER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1168410514 https://github.com/pydata/xarray/issues/6704#issuecomment-1168410514 https://api.github.com/repos/pydata/xarray/issues/6704 IC_kwDOAMm_X85FpIeS benbovy 4160723 2022-06-28T08:34:42Z 2022-06-28T08:34:42Z MEMBER

Should rename_dims also rename indexes (dimension coordinates)?

Sorry I think I misunderstood the question. If that means "should rename_dims also rename the (dimension) coordinates", then I think the answer should be no. With the explicit indexes refactor coordinates and indexes are less tightly coupled, i.e., in the mid/long term we want to drop the concept of a "dimension coordinate with an implicit index". So I think rename_dims should only rename dimensions (and update indexes metadata accordingly, cf. my previous comment).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Future of `DataArray.rename` 1275752720
1166980787 https://github.com/pydata/xarray/issues/6704#issuecomment-1166980787 https://api.github.com/repos/pydata/xarray/issues/6704 IC_kwDOAMm_X85Fjraz benbovy 4160723 2022-06-27T07:23:24Z 2022-06-27T07:25:13Z MEMBER

Should rename_dims also rename indexes (dimension coordinates)?

Yes, renaming dimensions and/or coordinates should be properly handled by indexes. Xarray's Index abstract class provides a rename method that may (should) be implemented in subclasses.

For example, PandasIndex and PandasMultiIndex both have a dim attribute that must match the dimension name (this attribute is required as in a near future it will be possible to set indexes for non-dimension coordinates).

PandasIndex.rename (PandasMultiIndex.rename) also renames the underlying pandas index (levels) according to the new coordinate name(s).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Future of `DataArray.rename` 1275752720

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);