home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

8 rows where author_association = "MEMBER" and issue = 125708367 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 4

  • shoyer 4
  • keewis 2
  • jhamman 1
  • dcherian 1

issue 1

  • DataArrays should display their coordinates in the natural order · 8 ✖

author_association 1

  • MEMBER · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
723241066 https://github.com/pydata/xarray/issues/712#issuecomment-723241066 https://api.github.com/repos/pydata/xarray/issues/712 MDEyOklzc3VlQ29tbWVudDcyMzI0MTA2Ng== keewis 14808389 2020-11-06T18:47:35Z 2020-11-06T18:48:54Z MEMBER

true, it seems I didn't read this issue carefully enough

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  DataArrays should display their coordinates in the natural order 125708367
723239452 https://github.com/pydata/xarray/issues/712#issuecomment-723239452 https://api.github.com/repos/pydata/xarray/issues/712 MDEyOklzc3VlQ29tbWVudDcyMzIzOTQ1Mg== dcherian 2448579 2020-11-06T18:44:07Z 2020-11-06T18:44:07Z MEMBER

4515 is consistent with this comment up above:

display coordinates corresponding to dimensions first in lists of coordinates, and to always display them in the same order as dimensions.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  DataArrays should display their coordinates in the natural order 125708367
723193550 https://github.com/pydata/xarray/issues/712#issuecomment-723193550 https://api.github.com/repos/pydata/xarray/issues/712 MDEyOklzc3VlQ29tbWVudDcyMzE5MzU1MA== keewis 14808389 2020-11-06T17:07:55Z 2020-11-06T17:07:55Z MEMBER

what should we do about this? We did touch the subject in #4409, but decided to keep the order the coordinates were passed in rather than sorting by dimension (or alphabetically). I think there's a lot of confusion about the difference between the dimensions in the summary line of DataArray objects and the order in the coordinates section.

A fix for #4515 might make sorting by dimension order much more important.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  DataArrays should display their coordinates in the natural order 125708367
458305117 https://github.com/pydata/xarray/issues/712#issuecomment-458305117 https://api.github.com/repos/pydata/xarray/issues/712 MDEyOklzc3VlQ29tbWVudDQ1ODMwNTExNw== jhamman 2443309 2019-01-28T21:18:13Z 2019-01-28T21:18:13Z MEMBER

@anntzer - would you be interested in working on this?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  DataArrays should display their coordinates in the natural order 125708367
211418692 https://github.com/pydata/xarray/issues/712#issuecomment-211418692 https://api.github.com/repos/pydata/xarray/issues/712 MDEyOklzc3VlQ29tbWVudDIxMTQxODY5Mg== shoyer 1217238 2016-04-18T15:04:30Z 2016-04-18T15:04:30Z MEMBER

OK, I didn't read your first post carefully last time. Your complaint was about the order of coordinates in ds.d1 and ds.d2, not the original DataArrays. So this is a more subtle issue than I thought.

We could add some sort of ad-hoc adjustment to the order in which we display coordinates, but I'm reluctant because it's not obvious to me what that "correct" order would be. For example, that you can directly supply the coords argument as a mapping with any arbitrary order to construct a DataArray.

I suppose once principled choice would always be to display coordinates corresponding to dimensions first in lists of coordinates, and to always display them in the same order as dimensions. If we do this, it should be consistent between both DataArray and Dataset.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  DataArrays should display their coordinates in the natural order 125708367
174843391 https://github.com/pydata/xarray/issues/712#issuecomment-174843391 https://api.github.com/repos/pydata/xarray/issues/712 MDEyOklzc3VlQ29tbWVudDE3NDg0MzM5MQ== shoyer 1217238 2016-01-26T05:41:28Z 2016-01-26T05:41:28Z MEMBER

This should be fixed in v0.7.0... please reopen if it resurfaces.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  DataArrays should display their coordinates in the natural order 125708367
170155759 https://github.com/pydata/xarray/issues/712#issuecomment-170155759 https://api.github.com/repos/pydata/xarray/issues/712 MDEyOklzc3VlQ29tbWVudDE3MDE1NTc1OQ== shoyer 1217238 2016-01-08T23:28:44Z 2016-01-08T23:28:44Z MEMBER

yes, in the next week, hopefully.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  DataArrays should display their coordinates in the natural order 125708367
170149315 https://github.com/pydata/xarray/issues/712#issuecomment-170149315 https://api.github.com/repos/pydata/xarray/issues/712 MDEyOklzc3VlQ29tbWVudDE3MDE0OTMxNQ== shoyer 1217238 2016-01-08T22:49:37Z 2016-01-08T22:50:03Z MEMBER

I think this may have been fixed by the recent rewrite of DataArray internals. On master, I have:

``` In [2]: d1 Out[2]: <xray.DataArray (foo: 2, bar: 2)> array([[ 0.00000000e+000, 0.00000000e+000], [ 2.15725662e-314, 2.15893204e-314]]) Coordinates: * foo (foo) int64 0 1 * bar (bar) int64 0 1

In [3]: d2 Out[3]: <xray.DataArray (bar: 2, foo: 2)> array([[ 0.00000000e+000, 0.00000000e+000], [ 2.15906985e-314, 2.14458868e-314]]) Coordinates: * bar (bar) int64 0 1 * foo (foo) int64 0 1 ```

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
  DataArrays should display their coordinates in the natural order 125708367

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);
Powered by Datasette · Queries took 34.514ms · About: xarray-datasette