issue_comments

Table actions

12 rows where author_association = "MEMBER" and issue = 1250755592 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • pre-release for v2022.06.0 · 12 ✖

author_association 1

  • MEMBER · 12 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1190471264 https://github.com/pydata/xarray/issues/6645#issuecomment-1190471264 https://api.github.com/repos/pydata/xarray/issues/6645 IC_kwDOAMm_X85G9SZg dcherian 2448579 2022-07-20T16:06:19Z 2022-07-20T16:06:19Z MEMBER

I'll issue the release once #6798 goes in.

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-release for v2022.06.0 1250755592
1170445824 https://github.com/pydata/xarray/issues/6645#issuecomment-1170445824 https://api.github.com/repos/pydata/xarray/issues/6645 IC_kwDOAMm_X85Fw5YA dcherian 2448579 2022-06-29T20:08:01Z 2022-06-29T20:08:01Z MEMBER

I added pre-release install instructions to whats-new and scheduled a tweet for 45 minutes from now (giving RTD enough time to build)

 
{
    "total_count": 2,
    "+1": 2,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-release for v2022.06.0 1250755592
1151353835 https://github.com/pydata/xarray/issues/6645#issuecomment-1151353835 https://api.github.com/repos/pydata/xarray/issues/6645 IC_kwDOAMm_X85EoEPr TomNicholas 35968931 2022-06-09T16:34:02Z 2022-06-09T16:34:02Z MEMBER

Nevermind, the answer was

it''s my understanding that the latest pre-release isn't published on conda-forge but on PyPI. Should it be put under the pip section ... pip: - xarray>=2022.6.0rc0

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-release for v2022.06.0 1250755592
1151342530 https://github.com/pydata/xarray/issues/6645#issuecomment-1151342530 https://api.github.com/repos/pydata/xarray/issues/6645 IC_kwDOAMm_X85EoBfC TomNicholas 35968931 2022-06-09T16:21:58Z 2022-06-09T16:25:08Z MEMBER

Thanks @keewis !

I just tried making a PR in datatree depend on this release, but the CI environment installation fails. I'm not sure if that's my fault or a problem with the release :confused: Any ideas? (@malmans2 FYI)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-release for v2022.06.0 1250755592
1151261404 https://github.com/pydata/xarray/issues/6645#issuecomment-1151261404 https://api.github.com/repos/pydata/xarray/issues/6645 IC_kwDOAMm_X85Entrc keewis 14808389 2022-06-09T15:20:39Z 2022-06-09T15:20:39Z MEMBER

I just published the pre-release, it can be installed from PyPI: python mamba create -n <name> python=3.10 xarray python -m pip install --pre --upgrade --no-deps xarray (the --no-deps is important, otherwise we pull the pre-releases of other packages)

 
{
    "total_count": 3,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 3,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-release for v2022.06.0 1250755592
1144982336 https://github.com/pydata/xarray/issues/6645#issuecomment-1144982336 https://api.github.com/repos/pydata/xarray/issues/6645 IC_kwDOAMm_X85EPwtA keewis 14808389 2022-06-02T15:13:21Z 2022-06-02T15:20:34Z MEMBER

As far as I remember the only reason we don't do that already is that setuptools_scm creates nightly version strings that are not compliant to PEP440. The version scheme appears to be configurable, but I couldn't find documentation on how to do that. As such, if anyone can figure out how to create PEP440 (and thus PyPI) compatible development versions I think we can have a CI publish every commit on main to TestPyPI.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-release for v2022.06.0 1250755592
1144455537 https://github.com/pydata/xarray/issues/6645#issuecomment-1144455537 https://api.github.com/repos/pydata/xarray/issues/6645 IC_kwDOAMm_X85ENwFx kmuehlbauer 5821660 2022-06-02T05:35:53Z 2022-06-02T05:35:53Z MEMBER

I'm wondering if it would be possible to publish every commit to main on https://test.pypi.org/project/xarray/? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-release for v2022.06.0 1250755592
1143737346 https://github.com/pydata/xarray/issues/6645#issuecomment-1143737346 https://api.github.com/repos/pydata/xarray/issues/6645 IC_kwDOAMm_X85ELAwC dcherian 2448579 2022-06-01T15:12:11Z 2022-06-01T15:12:11Z MEMBER

Do we need to update whats-new.rst for this

👍🏾 It'd be nice to point to "known regressions" to prevent a bunch of duplicate bug reports.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-release for v2022.06.0 1250755592
1143377823 https://github.com/pydata/xarray/issues/6645#issuecomment-1143377823 https://api.github.com/repos/pydata/xarray/issues/6645 IC_kwDOAMm_X85EJo-f keewis 14808389 2022-06-01T09:47:41Z 2022-06-01T09:47:41Z MEMBER

right, I misunderstood that MVCE. I still think that we don't need to wait on a fix to do the pre-release, though.

As far as I understand PEP440, to create a pre-release we just need add a rcN suffix (i.e. 2022.06.0rc0) or .devN (i.e. 2022.06.0.dev0. Do we need to update whats-new.rst for this?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-release for v2022.06.0 1250755592
1142395245 https://github.com/pydata/xarray/issues/6645#issuecomment-1142395245 https://api.github.com/repos/pydata/xarray/issues/6645 IC_kwDOAMm_X85EF5Ft dcherian 2448579 2022-05-31T17:07:02Z 2022-05-31T17:16:02Z MEMBER

The MVCE in #6607 does work on v2022.03.0. #6229 OTOH was broken earlier so technically not a regression

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-release for v2022.06.0 1250755592
1140243610 https://github.com/pydata/xarray/issues/6645#issuecomment-1140243610 https://api.github.com/repos/pydata/xarray/issues/6645 IC_kwDOAMm_X85D9rya keewis 14808389 2022-05-28T11:36:43Z 2022-05-28T11:37:14Z MEMBER

the cftime issues (#6624, #6613) look like they would be good to be fixed first, but since the remaining one (#6607) is also in 2022.3.0 I don't think we need to wait on that for the pre-release.

Something to remember, though, is that this is not a full release, so I don't think we need to have fixed every known bug / regression.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-release for v2022.06.0 1250755592
1140134005 https://github.com/pydata/xarray/issues/6645#issuecomment-1140134005 https://api.github.com/repos/pydata/xarray/issues/6645 IC_kwDOAMm_X85D9RB1 dcherian 2448579 2022-05-28T01:50:06Z 2022-05-28T01:50:06Z MEMBER

Doing a pre-release sounds good to me.

But we know of at least three regressions (tagged under "release-blocker"). Should we fix them first?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   pre-release for v2022.06.0 1250755592

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);