issue_comments

Table actions

5 rows where author_association = "MEMBER" and issue = 122776511 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 2

issue 1

  • to_netcdf on Python 3: "string" qualifier on attributes · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
226238810 https://github.com/pydata/xarray/issues/681#issuecomment-226238810 https://api.github.com/repos/pydata/xarray/issues/681 MDEyOklzc3VlQ29tbWVudDIyNjIzODgxMA== shoyer 1217238 2016-06-15T16:15:05Z 2016-06-15T16:15:05Z MEMBER

@byersiiasa What version of netCDF4-Python are you using? This was fixed in netCDF4-Python v1.2.3.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_netcdf on Python 3: "string" qualifier on attributes  122776511
190921447 https://github.com/pydata/xarray/issues/681#issuecomment-190921447 https://api.github.com/repos/pydata/xarray/issues/681 MDEyOklzc3VlQ29tbWVudDE5MDkyMTQ0Nw== shoyer 1217238 2016-03-01T21:49:36Z 2016-03-01T21:49:36Z MEMBER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_netcdf on Python 3: "string" qualifier on attributes  122776511
165547726 https://github.com/pydata/xarray/issues/681#issuecomment-165547726 https://api.github.com/repos/pydata/xarray/issues/681 MDEyOklzc3VlQ29tbWVudDE2NTU0NzcyNg== shoyer 1217238 2015-12-17T18:57:04Z 2015-12-17T18:57:04Z MEMBER

Yes, I would support this change.

On Thu, Dec 17, 2015 at 10:43 AM, Joe Hamman notifications@github.com wrote:

So an alternative choice would be to attempt to always encode unicode (str on Python 3) attributes as ASCII when saving with netCDF4, e.g.,

Exactly what I have done in the past.

Does this seem like something we should change/fix?

— Reply to this email directly or view it on GitHub https://github.com/xray/xray/issues/681#issuecomment-165543980.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_netcdf on Python 3: "string" qualifier on attributes  122776511
165543980 https://github.com/pydata/xarray/issues/681#issuecomment-165543980 https://api.github.com/repos/pydata/xarray/issues/681 MDEyOklzc3VlQ29tbWVudDE2NTU0Mzk4MA== jhamman 2443309 2015-12-17T18:42:36Z 2015-12-17T18:42:36Z MEMBER

So an alternative choice would be to attempt to always encode unicode (str on Python 3) attributes as ASCII when saving with netCDF4, e.g.,

Exactly what I have done in the past.

Does this seem like something we should change/fix? 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_netcdf on Python 3: "string" qualifier on attributes  122776511
165540231 https://github.com/pydata/xarray/issues/681#issuecomment-165540231 https://api.github.com/repos/pydata/xarray/issues/681 MDEyOklzc3VlQ29tbWVudDE2NTU0MDIzMQ== shoyer 1217238 2015-12-17T18:31:08Z 2015-12-17T18:31:08Z MEMBER

Yes, this is probably related to the netCDF4-python change discussed here: https://github.com/Unidata/netcdf4-python/issues/388

Unfortunately, lots of older netCDF programs don't know how to interpret the netCDF4 "string" dtype -- and to be honest, even the netCDF-C library doesn't always properly save such data as Unicode yet, though that should be fixed in the next release (4.4.0 -- see https://github.com/Unidata/netcdf-c/issues/127 for more details).

So an alternative choice would be to attempt to always encode unicode (str on Python 3) attributes as ASCII when saving with netCDF4, e.g.,

python def maybe_encode(string, encoding='ascii'): try: return string.encode(encoding) except UnicodeEncodeError: return string

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   to_netcdf on Python 3: "string" qualifier on attributes  122776511

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);