issue_comments

Table actions

4 rows where author_association = "MEMBER", issue = 1200581329 and user = 2443309 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • jhamman · 4 ✖

issue 1

  • implement Zarr v3 spec support · 4 ✖

author_association 1

  • MEMBER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1320701325 https://github.com/pydata/xarray/pull/6475#issuecomment-1320701325 https://api.github.com/repos/pydata/xarray/issues/6475 IC_kwDOAMm_X85OuE2N jhamman 2443309 2022-11-19T00:31:47Z 2022-11-19T00:31:47Z MEMBER

This is ready to merge once https://github.com/pydata/xarray/pull/7300 is in.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implement Zarr v3 spec support 1200581329
1304558730 https://github.com/pydata/xarray/pull/6475#issuecomment-1304558730 https://api.github.com/repos/pydata/xarray/issues/6475 IC_kwDOAMm_X85NwfyK jhamman 2443309 2022-11-05T14:38:18Z 2022-11-05T14:38:18Z MEMBER

@grlee77, @rabernat, @joshmoore, and others - I think this is ready to review and/or merge. The Zarr-V3 tests are active in the CI Upstream / upstream-dev GitHub Action. The test failure on readthedocs is unrelated to this PR.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implement Zarr v3 spec support 1200581329
1294086466 https://github.com/pydata/xarray/pull/6475#issuecomment-1294086466 https://api.github.com/repos/pydata/xarray/issues/6475 IC_kwDOAMm_X85NIjFC jhamman 2443309 2022-10-27T21:32:42Z 2022-10-27T21:32:42Z MEMBER

@grlee77 - I'm curious if you are planning to return to this PR or if it would be helpful if someone brought it to completion?

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   implement Zarr v3 spec support 1200581329
1281657040 https://github.com/pydata/xarray/pull/6475#issuecomment-1281657040 https://api.github.com/repos/pydata/xarray/issues/6475 IC_kwDOAMm_X85MZIjQ jhamman 2443309 2022-10-18T00:23:20Z 2022-10-18T00:23:20Z MEMBER

A separate issue is that consolidated metadata isn't in the core Zarr v3 spec, so we will need to have a Zarr Enhancement Proposal to formally define how the metadata should be stored. In the experimental API, it behaves as for v2 and is stored at /meta/root/consolidated by default.

I think it would be fine to disallow consolidated metadata for v3 until there is a spec in place. This is going to be experimental for some time so I don't see the harm in raising an error when consolidated=True and version=3. I think this is better than guessing what the v3 extension will specify.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   implement Zarr v3 spec support 1200581329

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);