issue_comments

Table actions

5 rows where author_association = "MEMBER", issue = 117002929 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • shoyer · 5 ✖

issue 1

  • Plotting on map projection much slower on v0.6.1 than 0.6.0 · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
226321246 https://github.com/pydata/xarray/issues/657#issuecomment-226321246 https://api.github.com/repos/pydata/xarray/issues/657 MDEyOklzc3VlQ29tbWVudDIyNjMyMTI0Ng== shoyer 1217238 2016-06-15T21:10:38Z 2016-06-15T21:10:38Z MEMBER

Strange... thanks for checking again.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting on map projection much slower on v0.6.1 than 0.6.0 117002929
157814683 https://github.com/pydata/xarray/issues/657#issuecomment-157814683 https://api.github.com/repos/pydata/xarray/issues/657 MDEyOklzc3VlQ29tbWVudDE1NzgxNDY4Mw== shoyer 1217238 2015-11-18T18:39:45Z 2015-11-18T18:39:45Z MEMBER

Profiling for each version of pcolormesh: https://gist.github.com/shoyer/73e3841827fe1eb08d00

Switching a masked array doesn't seem to make the non-xray version any slower...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting on map projection much slower on v0.6.1 than 0.6.0 117002929
157774815 https://github.com/pydata/xarray/issues/657#issuecomment-157774815 https://api.github.com/repos/pydata/xarray/issues/657 MDEyOklzc3VlQ29tbWVudDE1Nzc3NDgxNQ== shoyer 1217238 2015-11-18T16:48:06Z 2015-11-18T16:48:06Z MEMBER

Yes, I'm seeing the same thing. Very weird -- I'll see if I can profile it.

On Wed, Nov 18, 2015 at 8:28 AM, Fabien Maussion notifications@github.com wrote:

Was someone able to reproduce this or is it just me?

Reply to this email directly or view it on GitHub: https://github.com/xray/xray/issues/657#issuecomment-157768356

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting on map projection much slower on v0.6.1 than 0.6.0 117002929
156858837 https://github.com/pydata/xarray/issues/657#issuecomment-156858837 https://api.github.com/repos/pydata/xarray/issues/657 MDEyOklzc3VlQ29tbWVudDE1Njg1ODgzNw== shoyer 1217238 2015-11-15T21:53:30Z 2015-11-15T21:53:30Z MEMBER

Yes, the difference in speed is definitely due to cartopy, which handles the projections. @pelson may be able to clarify whether imshow is always slower than pcolormesh when using cartopy, or if that is specific to particular projections.

We changed the default from imshow to pcolormesh in #608. I would not be opposed to changing the default back, given that we already product essentially equivalent plots with both methods. We did add a performance note to our (currently broken) docs: http://xray.readthedocs.org/en/latest/plotting.html#two-dimensions

@jhamman and/or @clarkfitzg may have some opinions here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting on map projection much slower on v0.6.1 than 0.6.0 117002929
156847805 https://github.com/pydata/xarray/issues/657#issuecomment-156847805 https://api.github.com/repos/pydata/xarray/issues/657 MDEyOklzc3VlQ29tbWVudDE1Njg0NzgwNQ== shoyer 1217238 2015-11-15T19:59:27Z 2015-11-15T19:59:27Z MEMBER

We changed the default plot type from "imshow" in xray v0.6 to "pcolormesh" in xray v0.6.1. Does setting that manually make a difference? e.g., t2_avg.plot.imshow?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Plotting on map projection much slower on v0.6.1 than 0.6.0 117002929

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);