issue_comments

Table actions

5 rows where author_association = "MEMBER", issue = 115933483 and user = 1217238 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

user 1

  • shoyer · 5 ✖

issue 1

  • Feature/average · 5 ✖

author_association 1

  • MEMBER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
218321387 https://github.com/pydata/xarray/pull/650#issuecomment-218321387 https://api.github.com/repos/pydata/xarray/issues/650 MDEyOklzc3VlQ29tbWVudDIxODMyMTM4Nw== shoyer 1217238 2016-05-10T23:28:52Z 2016-05-10T23:28:52Z MEMBER

@MaximilianR great idea! A groupby like interface is much cleaner than adding more orthogonal code paths to .mean and the like.

 
{
    "total_count": 3,
    "+1": 0,
    "-1": 1,
    "laugh": 0,
    "hooray": 2,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/average 115933483
218302515 https://github.com/pydata/xarray/pull/650#issuecomment-218302515 https://api.github.com/repos/pydata/xarray/issues/650 MDEyOklzc3VlQ29tbWVudDIxODMwMjUxNQ== shoyer 1217238 2016-05-10T21:49:53Z 2016-05-10T21:49:53Z MEMBER

Do you know if a weighted mean is planned in pandas?

Like most new features for pandas (or xarray, for that matter), there isn't anyone who has committed to working on it -- it will depend on the interest of a contributor.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/average 115933483
186354428 https://github.com/pydata/xarray/pull/650#issuecomment-186354428 https://api.github.com/repos/pydata/xarray/issues/650 MDEyOklzc3VlQ29tbWVudDE4NjM1NDQyOA== shoyer 1217238 2016-02-19T18:36:22Z 2016-02-19T18:37:47Z MEMBER

I would still lean toward trying to put this into mean. You already have most of what you need -- it would just be a matter of dropping mean from the list of injected methods.

https://github.com/pydata/xarray/issues/770 might help with some of the redundant code (if/when we get around to it).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/average 115933483
156018718 https://github.com/pydata/xarray/pull/650#issuecomment-156018718 https://api.github.com/repos/pydata/xarray/issues/650 MDEyOklzc3VlQ29tbWVudDE1NjAxODcxOA== shoyer 1217238 2015-11-12T06:58:40Z 2015-11-12T06:58:40Z MEMBER

If you think the ability to return sum_of_weights is important, then this probably makes sense as a separate method -- that would be pretty confusing to add to mean. Otherwise, I would be inclined to simply add weights=None to mean. That would require a bit of refactoring but shouldn't be too bad.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/average 115933483
155357189 https://github.com/pydata/xarray/pull/650#issuecomment-155357189 https://api.github.com/repos/pydata/xarray/issues/650 MDEyOklzc3VlQ29tbWVudDE1NTM1NzE4OQ== shoyer 1217238 2015-11-10T08:29:44Z 2015-11-10T08:29:44Z MEMBER

Any thoughts on the tradeoff between adding average vs adding a weights argument to mean? I guess it's nice that this mirrors NumPy.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Feature/average 115933483

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);