issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 1124431593 and user = 10194086 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • mathause · 3 ✖

issue 1

  • Enable running sphinx-build on Windows · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1050186896 https://github.com/pydata/xarray/pull/6237#issuecomment-1050186896 https://api.github.com/repos/pydata/xarray/issues/6237 IC_kwDOAMm_X84-mJSQ mathause 10194086 2022-02-24T19:25:10Z 2022-02-24T19:25:10Z MEMBER

Thanks, that looks good to me - I'll merge in a day or two unless someone else has a comment.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable running sphinx-build on Windows 1124431593
1035010625 https://github.com/pydata/xarray/pull/6237#issuecomment-1035010625 https://api.github.com/repos/pydata/xarray/issues/6237 IC_kwDOAMm_X849sQJB mathause 10194086 2022-02-10T14:50:19Z 2022-02-10T14:50:19Z MEMBER

Yes your general approach looks good to me, so I am happy to take a closer look once you commit it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable running sphinx-build on Windows 1124431593
1031415667 https://github.com/pydata/xarray/pull/6237#issuecomment-1031415667 https://api.github.com/repos/pydata/xarray/issues/6237 IC_kwDOAMm_X849eidz mathause 10194086 2022-02-07T12:29:38Z 2022-02-07T12:29:38Z MEMBER

Thanks for your PR - we are definitely interested to make this work on windows. Instead of adding :okexcept: could we explicitly close the offending files?

For example could quick-overview.rst be fixed as follows:

```diff .. ipython:: python

ds.to_netcdf("example.nc")

.. ipython:: python :suppress:

import os

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Enable running sphinx-build on Windows 1124431593

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);