issue_comments

Table actions

3 rows where author_association = "MEMBER", issue = 1118113789 and user = 14808389 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • keewis · 3 ✖

issue 1

  • Fix missing dependecy definition of 'packaging' · 3 ✖

author_association 1

  • MEMBER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1025230165 https://github.com/pydata/xarray/pull/6207#issuecomment-1025230165 https://api.github.com/repos/pydata/xarray/issues/6207 IC_kwDOAMm_X849G8VV keewis 14808389 2022-01-30T21:01:12Z 2022-01-30T21:05:48Z MEMBER

other than the environment files and the asv config we also need to update doc/getting-started/installing.rst: the Required dependencies section, and maybe also the Minimum dependency versions. For the latter, we need to figure out a rule, though. For setuptools we had "42 months, but no older than 40.4", where 40.4 was the oldest version of setuptools installable from conda-forge.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix missing dependecy definition of 'packaging' 1118113789
1025228982 https://github.com/pydata/xarray/pull/6207#issuecomment-1025228982 https://api.github.com/repos/pydata/xarray/issues/6207 IC_kwDOAMm_X849G8C2 keewis 14808389 2022-01-30T20:54:39Z 2022-01-30T20:54:39Z MEMBER

just for the record, we decided that packaging related tools (i.e. setuptools, not sure if that also applies to packaging) should be released just before the earliest supported python version, so we would have to decide between 19.2 and 20. However, since the release notes of packaging state that 20 is the first version to officially support py38 I'd say using packaging>=20 should be uncontroversial.

 
{
    "total_count": 4,
    "+1": 4,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix missing dependecy definition of 'packaging' 1118113789
1024993880 https://github.com/pydata/xarray/pull/6207#issuecomment-1024993880 https://api.github.com/repos/pydata/xarray/issues/6207 IC_kwDOAMm_X849GCpY keewis 14808389 2022-01-29T21:55:50Z 2022-01-29T21:55:50Z MEMBER

no, I think we should still add packaging to the dependencies, even if it doesn't cause any failures: we unconditionally import it in at least xarray.core.pycompat. We need to add a reasonable minimum version, though.

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix missing dependecy definition of 'packaging' 1118113789

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);