issue_comments

Table actions

14 rows where author_association = "MEMBER" and issue = 1118113789 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

issue 1

  • Fix missing dependecy definition of 'packaging' · 14 ✖

author_association 1

  • MEMBER · 14 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions performed_via_github_app issue
1026327684 https://github.com/pydata/xarray/pull/6207#issuecomment-1026327684 https://api.github.com/repos/pydata/xarray/issues/6207 IC_kwDOAMm_X849LISE max-sixty 5635139 2022-01-31T23:51:54Z 2022-01-31T23:51:54Z MEMBER

I'll merge now though do the release this eve

 
{
    "total_count": 4,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 3,
    "eyes": 0
}
   Fix missing dependecy definition of 'packaging' 1118113789
1026306642 https://github.com/pydata/xarray/pull/6207#issuecomment-1026306642 https://api.github.com/repos/pydata/xarray/issues/6207 IC_kwDOAMm_X849LDJS jhamman 2443309 2022-01-31T23:16:11Z 2022-01-31T23:16:11Z MEMBER

This is ready to merge. @max-sixty - whenever you are ready, go ahead and merge and make the release.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix missing dependecy definition of 'packaging' 1118113789
1025992494 https://github.com/pydata/xarray/pull/6207#issuecomment-1025992494 https://api.github.com/repos/pydata/xarray/issues/6207 IC_kwDOAMm_X849J2cu jhamman 2443309 2022-01-31T16:54:46Z 2022-01-31T16:58:13Z MEMBER

@pydata/xarray - we should try to get this merged and a new release up ASAP as bug reports are starting to pile up. I've pushed changes to the CI configs, documentation, and elsewhere. I've also pulled in the recent changes on main which should hopefully fix the failing CI in the first commit.

Also, thanks @s-weigand for opening this PR and raising the issue.

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix missing dependecy definition of 'packaging' 1118113789
1025994647 https://github.com/pydata/xarray/pull/6207#issuecomment-1025994647 https://api.github.com/repos/pydata/xarray/issues/6207 IC_kwDOAMm_X849J2-X max-sixty 5635139 2022-01-31T16:57:00Z 2022-01-31T16:57:00Z MEMBER

I can do the release later today if no one gets there first

 
{
    "total_count": 4,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 1,
    "eyes": 0
}
   Fix missing dependecy definition of 'packaging' 1118113789
1025230165 https://github.com/pydata/xarray/pull/6207#issuecomment-1025230165 https://api.github.com/repos/pydata/xarray/issues/6207 IC_kwDOAMm_X849G8VV keewis 14808389 2022-01-30T21:01:12Z 2022-01-30T21:05:48Z MEMBER

other than the environment files and the asv config we also need to update doc/getting-started/installing.rst: the Required dependencies section, and maybe also the Minimum dependency versions. For the latter, we need to figure out a rule, though. For setuptools we had "42 months, but no older than 40.4", where 40.4 was the oldest version of setuptools installable from conda-forge.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix missing dependecy definition of 'packaging' 1118113789
1025228982 https://github.com/pydata/xarray/pull/6207#issuecomment-1025228982 https://api.github.com/repos/pydata/xarray/issues/6207 IC_kwDOAMm_X849G8C2 keewis 14808389 2022-01-30T20:54:39Z 2022-01-30T20:54:39Z MEMBER

just for the record, we decided that packaging related tools (i.e. setuptools, not sure if that also applies to packaging) should be released just before the earliest supported python version, so we would have to decide between 19.2 and 20. However, since the release notes of packaging state that 20 is the first version to officially support py38 I'd say using packaging>=20 should be uncontroversial.

 
{
    "total_count": 4,
    "+1": 4,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix missing dependecy definition of 'packaging' 1118113789
1025200701 https://github.com/pydata/xarray/pull/6207#issuecomment-1025200701 https://api.github.com/repos/pydata/xarray/issues/6207 IC_kwDOAMm_X849G1I9 Illviljan 14371165 2022-01-30T18:23:53Z 2022-01-30T18:23:53Z MEMBER

Following dask seems like a good idea! We probably should add packaging in our ci installs as well: https://github.com/pydata/xarray/tree/main/ci/requirements and the asv config: https://github.com/pydata/xarray/blob/main/asv_bench/asv.conf.json

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix missing dependecy definition of 'packaging' 1118113789
1024993880 https://github.com/pydata/xarray/pull/6207#issuecomment-1024993880 https://api.github.com/repos/pydata/xarray/issues/6207 IC_kwDOAMm_X849GCpY keewis 14808389 2022-01-29T21:55:50Z 2022-01-29T21:55:50Z MEMBER

no, I think we should still add packaging to the dependencies, even if it doesn't cause any failures: we unconditionally import it in at least xarray.core.pycompat. We need to add a reasonable minimum version, though.

 
{
    "total_count": 3,
    "+1": 3,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix missing dependecy definition of 'packaging' 1118113789
1024956677 https://github.com/pydata/xarray/pull/6207#issuecomment-1024956677 https://api.github.com/repos/pydata/xarray/issues/6207 IC_kwDOAMm_X849F5kF max-sixty 5635139 2022-01-29T17:50:02Z 2022-01-29T17:50:02Z MEMBER

Thanks everyone! Are we ok to close this then?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix missing dependecy definition of 'packaging' 1118113789
1024896079 https://github.com/pydata/xarray/pull/6207#issuecomment-1024896079 https://api.github.com/repos/pydata/xarray/issues/6207 IC_kwDOAMm_X849FqxP mathause 10194086 2022-01-29T11:47:42Z 2022-01-29T11:47:42Z MEMBER

Yes, I think I just expressed it wrong. What I wanted to say: zhe failure you see here is not caused by #6200 but by a new release of dask. And this is independent of your issue with packaging.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix missing dependecy definition of 'packaging' 1118113789
1024896045 https://github.com/pydata/xarray/pull/6207#issuecomment-1024896045 https://api.github.com/repos/pydata/xarray/issues/6207 IC_kwDOAMm_X849Fqwt Illviljan 14371165 2022-01-29T11:47:29Z 2022-01-29T11:47:29Z MEMBER

https://docs.python.org/3/whatsnew/3.10.html#distutils-deprecated recommends importing packaging instead, so if we want to do version checking maybe we should just add it as a dependency?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix missing dependecy definition of 'packaging' 1118113789
1024884846 https://github.com/pydata/xarray/pull/6207#issuecomment-1024884846 https://api.github.com/repos/pydata/xarray/issues/6207 IC_kwDOAMm_X849FoBu mathause 10194086 2022-01-29T10:30:23Z 2022-01-29T10:55:14Z MEMBER

Thanks. I think it makes sense to revert #6200 then, it's not critical. I opened #6208 for this.

Thanks for the report and the PR.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
   Fix missing dependecy definition of 'packaging' 1118113789
1024887103 https://github.com/pydata/xarray/pull/6207#issuecomment-1024887103 https://api.github.com/repos/pydata/xarray/issues/6207 IC_kwDOAMm_X849Fok_ mathause 10194086 2022-01-29T10:46:12Z 2022-01-29T10:46:12Z MEMBER

On second thought I think the problem is the release of dask 2022.01.1.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix missing dependecy definition of 'packaging' 1118113789
1024884870 https://github.com/pydata/xarray/pull/6207#issuecomment-1024884870 https://api.github.com/repos/pydata/xarray/issues/6207 IC_kwDOAMm_X849FoCG mathause 10194086 2022-01-29T10:30:38Z 2022-01-29T10:30:38Z MEMBER

cc @pydata/xarray 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
   Fix missing dependecy definition of 'packaging' 1118113789

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [performed_via_github_app] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
);
CREATE INDEX [idx_issue_comments_issue]
    ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
    ON [issue_comments] ([user]);